From: sashiko-bot@kernel.org
To: haibo.chen@oss.nxp.com
Cc: Frank.Li@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH] arm64: dts: imx91-9x9-qsb: add CAN support overlay file
Date: Fri, 10 Jul 2026 10:16:14 +0000 [thread overview]
Message-ID: <20260710101614.BA8A01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260710-dts-imx91-can1-v1-1-c78c9c378e8d@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree overlay references an undefined phandle `<&can_fun>` and omits the `pinctrl-gpiomux` node described in the commit message, causing a build failure.
--
--- Patch [1]: [PATCH] arm64: dts: imx91-9x9-qsb: add CAN support overlay file ---
commit ba3a1378093445c34dbdd034a8296e7aaebdd0da
Author: Haibo Chen <haibo.chen@nxp.com>
arm64: dts: imx91-9x9-qsb: add CAN support overlay file
This commit adds a device tree overlay to enable CAN1 support on the
i.MX91 9x9 QSB board. It configures the TJA1057GT/3 PHY and sets up
the CAN1 pins.
> diff --git a/arch/arm64/boot/dts/freescale/imx91-9x9-qsb-can1.dtso b/arch/arm64/boot/dts/freescale/imx91-9x9-qsb-can1.dtso
> new file mode 100644
> index 0000000000000..b8343d653e511
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx91-9x9-qsb-can1.dtso
[ ... ]
> +&flexcan1 {
> + phys = <&flexcan_phy>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flexcan1>, <&can_fun>;
[Severity: Low]
Does this overlay build successfully? The device tree overlay references
the can_fun phandle, but it does not appear to be defined here or in the
base device tree.
The commit message mentions a pinctrl-gpiomux node for can_fun, but it seems
to be missing from the patch. When the Makefile applies this overlay, will
fdtoverlay fail due to the unresolved reference?
> + status = "okay";
> +};
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260710-dts-imx91-can1-v1-1-c78c9c378e8d@nxp.com?part=1
next prev parent reply other threads:[~2026-07-10 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 10:12 [PATCH] arm64: dts: imx91-9x9-qsb: add CAN support overlay file haibo.chen
2026-07-10 10:16 ` sashiko-bot [this message]
2026-07-10 10:52 ` Bough Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260710101614.BA8A01F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox