From: sashiko-bot@kernel.org
To: "Francesco Dolcini" <francesco@dolcini.it>
Cc: imx@lists.linux.dev, robh@kernel.org,
dri-devel@lists.freedesktop.org, Frank.Li@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 4/4] ARM: dts: imx7-colibri: Set LCDIF format
Date: Fri, 17 Jul 2026 12:30:30 +0000 [thread overview]
Message-ID: <20260717123031.6B1F91F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260717121847.488148-5-francesco@dolcini.it>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message body incorrectly refers to `colibri imx6ull` instead of `colibri imx7`.
--
--- Patch [4]: [PATCH v1 4/4] ARM: dts: imx7-colibri: Set LCDIF format ---
commit 9c45712860f8ad12db4bc3a18c8c4e7039c7f51b
Author: Francesco Dolcini <francesco.dolcini@toradex.com>
ARM: dts: imx7-colibri: Set LCDIF format
This commit updates the device tree for the Colibri i.MX7 to explicitly set
the LCDIF pixel format to rgb666 for its 18-bit width bus.
> The lcd DPI interface on colibri imx6ull uses a 18-bit width bus, set
> the interface-pix-fmt accordingly.
[Severity: Medium]
Is this description accurate for this patch? The subject and the modified
file (imx7-colibri.dtsi) both target the i.MX7 hardware, but the commit
message body mentions the colibri imx6ull. Should this text be updated to
refer to the i.MX7?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260717121847.488148-1-francesco@dolcini.it?part=4
prev parent reply other threads:[~2026-07-17 12:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 12:18 [PATCH v1 0/4] drm: mxsfb: Support LCDIF interface pixel format Francesco Dolcini
2026-07-17 12:18 ` [PATCH v1 1/4] dt-bindings: lcdif: Add " Francesco Dolcini
2026-07-17 12:28 ` sashiko-bot
2026-07-17 15:55 ` Frank Li
2026-07-17 20:57 ` Francesco Dolcini
2026-07-17 21:13 ` Francesco Dolcini
2026-07-17 12:18 ` [PATCH v1 2/4] drm: mxsfb: Allow optional LCDIF interface format override Francesco Dolcini
2026-07-17 12:18 ` [PATCH v1 3/4] ARM: dts: imx6ull-colibri: Set LCDIF format Francesco Dolcini
2026-07-17 12:18 ` [PATCH v1 4/4] ARM: dts: imx7-colibri: " Francesco Dolcini
2026-07-17 12:30 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717123031.6B1F91F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=francesco@dolcini.it \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox