From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7759D378D71 for ; Sat, 18 Jul 2026 23:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784417764; cv=none; b=trpNDQVhOHW95NSGPhHVKqjTlhUIt3k3QWjH+38K+LmC1vs8TNoxJKhjB5oTPF26t+E/Beos5SAzI/Xmv2PWeiwM6JU/pQ44JN6U4Ri6jDIQjgqEXWtLsuSJcboL3uWtcyUwlS4Mtw2WsF3S7heuW0ilkRKlKaobJn8Tb0KMQvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784417764; c=relaxed/simple; bh=/ymnttl7oB89lytF5t8kzEi7A56W5KOk4Klf25QHF00=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oJlPSarnZEXGW5/iJSbmkC9NZ2Ni9HcnEVQsz/edbRevDOv4iUFpkRYEJcCcLPxIEb6WENV77AkCLWUlQ8tEuM+J7NOW9pdb4UOsgTG88OIQeSzRm4Z9XYJeFbPTGJQxs5tl5ECgLYac+wQlhhNDwdr/PyOnOky3i29kFOeeL8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sgpMjj8N; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sgpMjj8N" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-471eeac43bfso8362575f8f.3 for ; Sat, 18 Jul 2026 16:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784417761; x=1785022561; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qVQM0So1MCL7ilj5LYZg6mzfa82XvkJyQz/kOpkAFIY=; b=sgpMjj8NJqzwznLGgnPmFrgCx/WtYuGxZz7FWdYsj1MKXQafv5IFIfk7zTWkwwlJFP vuTwPyji1h1kTXfszuDhudF1MvSrmyoxxNGYgN39UroB7OtWf1jg8qoWBtr5CJ9hFj/g m4jdMQYVluWiu/umwdWTwN43N9hbamZT2B9Fs9oGjAc1k3OpQ34JWz0pJZ/1au6qdEUb y6prowR9ggRdZa8R1f7Doq9gAiln8seKBaeEGqE/cOnh7GTxivRIhMIjAyfnS/rGQ+YP /e4cyM/bwmZt5D7ErTMImkAT1u64gUTyQcjNLLGuJQFUZ3FkSBAYFLclfWUOyLA2ku67 cW0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784417761; x=1785022561; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qVQM0So1MCL7ilj5LYZg6mzfa82XvkJyQz/kOpkAFIY=; b=a5ELbUSjAMdSikeAvWtVJLeKEH42c7Yw67YmbqPBjiBM7tonDVQq+Eyj/9ydBcDDFP xEGnrIIilfX42e1uHCyMw/gc1zIEHD0Dy3VNvqdYC8PWisy9a0AeZE6wJdMrA8f7PXCy VbjJ6oCemBbPey8Qm37cXLia5iCHiITcS7qwrnIyvzl8eqbmRtqwGxyEsa8WgyWHB4h5 FijQgwkRO+85XYxOkUrBshfSQiPFTMesee0kUhoLZAB99yCG7b4sMPUqmooLFycoFkIM SUtoHsh6PuklpH2lx0L12Tjz87EZwueGssuxNGemWyknLQDjK0U62udRHa8Od0YXoEDk KpBg== X-Forwarded-Encrypted: i=1; AHgh+Rq6YSbGC9fRTGD8QZK6ZZ9XUo2Aulkb9dKBh5bla1teMHs1AHtxm0+fKjQObUvw0tP6Ss8=@lists.linux.dev X-Gm-Message-State: AOJu0Yw3gNM2hQrrhAsMq4crfYFnp85jKJ9NthPn7IpfSPXiGf5Z31z3 DetTPw5AT+Ft5xcRlScrryLixA6QpePh1mWoXVO31i4xUzfeEwpKLYoo X-Gm-Gg: AfdE7ck+QD3oW0R/5ocD7aw8cbW+rwvbmcPevAs34tv623JCbbpOfkCIQxmmCWHG7+L nuDh6FkDaa611yhn9fgWhUdVvLJUJDZXvZEQyUycvrte818J3c0VQbOTIxEj8mM7aOxLrZVSBpD 3sOQP7Ej0bb0AsqTq6H3XI08z7MnTukFwAI+hl1XlqPJX5r96b2cf7LXQtpGKvgpUYZ7JaUOy2j Xp5YTnkGROEw4H+zF5ftVMq8/6ZSboduWPMoqPxAozkw+Ny0nU/Xs7xCrFfebaAK0z69UBEUQaT s8EZSCEB1aEmBvY23hPQZgIUIm2J9xzEQWuF1QATNcAdZG6NWw1DZl2CJ2qBet91gixi/mkdToo KUVoUPpGUX1DcoHDDfXaDBGZVgDx/o2R+qr+Oj44R4NvoO2bzcv2+bQXdSFD5EC1NGx22YgeH3A fiJh7C5bWkZQ== X-Received: by 2002:a05:600c:4e94:b0:495:571e:e5d3 with SMTP id 5b1f17b1804b1-495571ee75fmr14134205e9.36.1784417760679; Sat, 18 Jul 2026 16:36:00 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:645b:9e5c:7fe3:c09f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a24b6sm160964675e9.3.2026.07.18.16.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 16:36:00 -0700 (PDT) From: Diogo Silva Date: Sun, 19 Jul 2026 01:35:32 +0200 Subject: [PATCH 01/15] drm/exynos: remove dependency on DRM simple helpers Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260719-drm_simple_encoder_init-v1-1-a78c509e3062@gmail.com> References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> In-Reply-To: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/exynos/exynos_dp.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 14 ++++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++++++++-- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 14 ++++++++++++-- drivers/gpu/drm/exynos/exynos_hdmi.c | 15 +++++++++++++-- 5 files changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index b80540328150..1598892c602b 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -24,11 +24,11 @@ #include #include #include +#include #include #include #include #include -#include #include #include "exynos_drm_crtc.h" @@ -79,6 +79,10 @@ static void exynos_dp_nop(struct drm_encoder *encoder) /* do nothing */ } +static const struct drm_encoder_funcs exynos_dp_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs exynos_dp_encoder_helper_funcs = { .mode_set = exynos_dp_mode_set, .enable = exynos_dp_nop, @@ -95,7 +99,12 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) dp->drm_dev = drm_dev; - drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); + ret = drm_encoder_init(drm_dev, encoder, &exynos_dp_encoder_funcs, + DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + dev_err(dp->dev, "Failed to initialize encoder\n"); + return ret; + } drm_encoder_helper_add(encoder, &exynos_dp_encoder_helper_funcs); diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 0dc36df6ada3..4e42a1da81d1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c @@ -12,10 +12,10 @@ #include #include +#include #include #include #include -#include #include