From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0401D436BCF for ; Mon, 20 Jul 2026 15:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562093; cv=none; b=DlD7ZI/CDreRfHpI1V6NnCYyu3l5Ivar17gurpvkkOltRA17oJsHN2giTsBVdCpjmBmg9WnvY+HV2V/mDGg0eqdC2NnVMSpf4cOVMNQ4ag4Zcbmg9VeXBPQmoFuLciM4ClxcX6CAl9vDJl/Z3RRZ6FJUxMomWcldXiqRAmx381g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562093; c=relaxed/simple; bh=b45v6y+LLUGyopM335rc2RHdtrcJI8ZwsczKTNDgp+c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VNCS0ouzu7hg9l0Qai5VW5WRmF5IIbaqyLFqR5JrGTT2JuAb+vX4jYLB4VKQDuPELGMsdq1DaDD7J+U+kYYyNTvj5hYCDUW8kxinx/r0a+gbBBef3ZbQ8lY7y2yl8s0EEdeXNNNjwrnjmqIodiqY1pl1oydZHJ4Fcec8OE9hDOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AwO/oSK7; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AwO/oSK7" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4955adb04e8so10429755e9.2 for ; Mon, 20 Jul 2026 08:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562088; x=1785166888; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UCTzuFV7eFCGxIzO9ORcmzHtSM3Ggk/jrKBR0xDgYaA=; b=AwO/oSK7/J2gehH9hix2ybFHn5TIvV2BohEIvnCVPYrVNbVAWkiKdiHMV6R2LRztka RfIdMsWX3X2b/kTrEZqqhxGs6CB/D7nXb7UKvrGvA6OT/z+nfKNRv9b6cgvC7sm4HF08 /1yfMtWB9oLgay0qcqsBZnY7aaMUxefGAgHNYCVi7ZdnOOsOmtWKVn54bPupbWaP0tPc ACf/8UAqIm/5o/hklHnMyXGLxAa20mfVeXou35pARoYm2yO3hpTgWUaw0kaipLvsqRld MYfKyj7OZ0sEkcKSBiSTX0sNiC6OIJEoc9kb4QgsEV2jrO2uf4p1T3wyI2bGHg1r6paw 3iKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562088; x=1785166888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UCTzuFV7eFCGxIzO9ORcmzHtSM3Ggk/jrKBR0xDgYaA=; b=DUJqQ7I4rMze5a7dCCU2xJhGClWCQzka6hE88NSgem9QiECIWxofrddNhNDDAwyU/l 7KyqWX6lguMslaYMp7q+qWbVZNkhO7KfSryEls4Oi6gVqtxiUbOcz2EHRvOzR5jkFJM0 yMaOxXBV0nlczG+1EOGzqmKKSd3kce74vhh9FPyij5HM3oLP1J78hX5nBN4N1AdFxmbE 0nFgCsgEcmGasxvsTZQsYm7rlXfLYQslGTKLK7JpsxdRmxyGvKNQBHkpMhHLOPMyiOA8 fW5ZI35GGVdssPVWateP7LjHYBul7qI8rw60YSzk28u9qOKtbj+gU19hL/tyaZ4VQ+9F rB5A== X-Forwarded-Encrypted: i=1; AHgh+Rqtegayeq4Y1jxR/+J5nPa1rjV1LZJGdhJN2CjVjZxQPfH1MEjBiYdlC3ItIg6eC8t2ni4=@lists.linux.dev X-Gm-Message-State: AOJu0Yy7VBPsqv1LWToJC8eqnPrcwGzp6Y7/EKFpKDL6I2KPuj1NtPgy ieHQhPcqa+kwIvzykx1HmrAtFqXoOivTQb44H0Q4tpcl5cOIbzTdnqQh X-Gm-Gg: AfdE7cmITtxXYBvkpD8qcCwiu1s9NPpwiGsCTzQqjzpq5lvP2gTOLWlyJq2gUsd4tDR NM/kljBInyFfycXSM9JYsFsVUzH++EPINhYR94ouJAb4GMOK0D2rIybrLaI5JAC78/Hs4yTrPdx PMNREb1fsNFKpwQaFjxFKvPq9d+/eaiPH1jJ0gfFL7qqLcEvy42z/EvM2IupsRH2gzMdgZgWYle 0oAZaPDZTVW19nngwcYcxpXMivdQkBy25DU0JhkGacaB9zJLL2a/lpGFjVpUjGdIIXjDeptdoI9 IJz3d96uejgWgAQaD9QxV1xFWdg7zkyR5dzNold+vrcCCJrNZMeMJWwT9wRGEmaGKFTMjKy6Yn5 /PDABWoCmcHqC1Gpcv3VztzRK1yZUZdkAHNCAQF/HucAcKDtAWBausyYd+GVY6AJbxUsMgu0b9P FwztFUPKsBGzne4xXbmofV X-Received: by 2002:a05:600c:1d1e:b0:493:b6ee:fcb7 with SMTP id 5b1f17b1804b1-4954a3f39ffmr153406895e9.14.1784562088052; Mon, 20 Jul 2026 08:41:28 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:41:27 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:43 +0200 Subject: [PATCH v2 11/15] drm/hisilicon/kirin: remove dependency on DRM simple helpers Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-11-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Signed-off-by: Diogo Silva --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c index 15042365dec0..62c5bd3277da 100644 --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c @@ -20,11 +20,11 @@ #include #include #include +#include #include #include #include #include -#include #include "dw_dsi_reg.h" @@ -687,6 +687,10 @@ static int dsi_encoder_atomic_check(struct drm_encoder *encoder, return 0; } +static const struct drm_encoder_funcs dw_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs dw_encoder_helper_funcs = { .atomic_check = dsi_encoder_atomic_check, .mode_valid = dsi_encoder_mode_valid, @@ -708,7 +712,8 @@ static int dw_drm_encoder_init(struct device *dev, } encoder->possible_crtcs = crtc_mask; - ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_DSI); + ret = drm_encoder_init(drm_dev, encoder, &dw_encoder_funcs, + DRM_MODE_ENCODER_DSI, NULL); if (ret) { DRM_ERROR("failed to init dsi encoder\n"); return ret; -- 2.54.0