From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 657A6422540 for ; Mon, 20 Jul 2026 15:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562057; cv=none; b=BMAIha2gDw4SYhmTeE44bR5+ZGkfZPNc9WQqOazXKwmv2QZ70+P+T+ptrDYmKZM4LjUmhpNVg40xilQ4/SB/+rxdXUFjRFX6SpSC06zlHfwpi0dmayP0JTW0Ioptc9uI1CYTrCKDxw/tn1l4oTb/kdEUs4r/weY+HHMdT5iI6wI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562057; c=relaxed/simple; bh=nIPzxyC7g+URQtzWP7eUGE6nO5tW3SAcscwh0lKy5F8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mtH/3sL+EydLM/Y3/XYaiMJqcj+2o96H0QCVNZpLz1A0/kFQ//BVDhZEcYJMcl96LS5MNQ/om8wiTaYXC426CaRdBdnQn+GCEgfl3iVBPpcyRdopH3xCQlp+sP0hQkZuXY6K+BdgRi+hZe9XwBT/5L73cNDIlP2BG7Wd0QTXo98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hRV9fk8S; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hRV9fk8S" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-47df43bfb07so2743087f8f.1 for ; Mon, 20 Jul 2026 08:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562053; x=1785166853; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Pvez7dBBgFzTEWul+X0zgtK0IubmPdgVdOv0lVVEMOs=; b=hRV9fk8Sx+sAvBNioVgjEzrcep46NQAdNtQfN8YRm57TwzrWnpSfEG+N5iGtwhYCSL bzeaBAgz+xbSSmh9PBNgnK4o/iBtDVKWnVOn7ms7NjvYx4gH9jaR9R97zvOJG8gY1TYy ZtUHJvQvVZzEtim4GQr1HD6+CsIA1oeP6xgxXZ0KROsvCoh0/r9h/N3XD+/hoOu/Ck8s AhikQa4LejTn0JFYrvKmJBygbacfD7WdFBhI6ezqEYCTMMItKZ0PetCBBmGp8SXhub9/ mHGgM0txpyByZyuc/tmoFPKoz2pPy9NIt/xhTQCTWYaapqGFk5vMd1RCtKf/IwK7e+yf 4Dcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562053; x=1785166853; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Pvez7dBBgFzTEWul+X0zgtK0IubmPdgVdOv0lVVEMOs=; b=V7rsNqIVRcGaEiN05aW8shpCuoeOa0qyU4e+RrUtACIcAxF8sghVH6h8F8xiA4dq00 0mukY5mb2YjbXPjHGCCv/z2viuGD/6rCk33C4yAhGlni+5q2h1nWmaM9mIxlk/RYqrrU s46Nnrfjg/tlb6FCTt9sWZUpjyuXSnVch4l+cq1sEqVKnDlIMban8UqRKEpfzFmqdIjM 6aF3oWyrrIai2drgcSFOKjV/oCQ/AIFQkQ3FaPoHEK0qtnsc4i1PMbA1TgaJ1Q/j5ZFQ q29WRTJXio6sjWlgar4TZGduODtz7LqarFwAcNhiNOioYbxoaiebipltLCy6eO4yBWpS +3hg== X-Forwarded-Encrypted: i=1; AHgh+RrLCS5JYUJbuLJLJDWIUIGRj2ow2bxxf5yiNt4QqH8ovgSeyKu1pAwzVTC4064EuiX+gfM=@lists.linux.dev X-Gm-Message-State: AOJu0YwU6KIiAoHeBQaqIqi2U5tI0NRuuuGzSk7zHs6NYeMdZFdDwcDB fYCF/f+EhNQ0ivMawqfshQ4EZ78bwH6EQDs1Yesw9kgsTxi0KZV4d3Pv X-Gm-Gg: AR+sD10B5tPT5i283cgHAxaGedKd4JS3yW6XNcIsXEfqL7150dY5EUGLfk+sfPgUriT IPaGFUos9UmH3qqTaaj7f8MMce+GfcDwuocCf4savxjOlT4DUlS9RDuHM3vFfebKHVI0bkKY7Ev SUPh7RMQ3hhbnkSBapHzD3iQaFhNSiI06nAv9qFn9F073yiKVYsVLJvG23/0opKDbMmxy7C+gxv /npIutgFM1fk2fVPDM4hS811fsy82SznMqPWnCyHYIKuc3yuJgHaCBqWaC2uc3qCx0lzB/LBxs2 Jci1aA35KsOt6QxDGjdPnsV1YItU8opkctjEoRhDnFA+GuLyp45yINBXbcAg3JmiBzZXg4dzSp3 m+y2siy2gDF7CRS7gNti/BP407D+vokwG0t/8q/SRX3NS1KahPcNitQAt1J6vCIk1+VsWfo+nCW cYzDm/Xg2sWA== X-Received: by 2002:adf:f604:0:b0:475:f0f0:9ef6 with SMTP id ffacd0b85a97d-47f6233f338mr13274205f8f.59.1784562053525; Mon, 20 Jul 2026 08:40:53 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:40:52 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:34 +0200 Subject: [PATCH v2 02/15] drm/xlnx/zynqmp_dpsub: remove dependency on DRM simple helpers Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-2-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c index d5f922450565..ac9197e026af 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -29,8 +29,8 @@ #include #include #include +#include #include -#include #include #include @@ -417,6 +417,10 @@ static const struct drm_driver zynqmp_dpsub_drm_driver = { .minor = 0, }; +static const struct drm_encoder_funcs zynqmp_dpsub_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static int zynqmp_dpsub_kms_init(struct zynqmp_dpsub *dpsub) { struct drm_encoder *encoder = &dpsub->drm->encoder; @@ -436,7 +440,13 @@ static int zynqmp_dpsub_kms_init(struct zynqmp_dpsub *dpsub) /* Create the encoder and attach the bridge. */ encoder->possible_crtcs |= drm_crtc_mask(&dpsub->drm->crtc); - drm_simple_encoder_init(&dpsub->drm->dev, encoder, DRM_MODE_ENCODER_NONE); + ret = drm_encoder_init(&dpsub->drm->dev, encoder, + &zynqmp_dpsub_encoder_funcs, + DRM_MODE_ENCODER_NONE, NULL); + if (ret) { + drm_err(&dpsub->drm->dev, "failed to initialize encoder\n"); + return ret; + } ret = drm_bridge_attach(encoder, dpsub->bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); -- 2.54.0