From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A8DC41169E for ; Mon, 20 Jul 2026 15:40:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562061; cv=none; b=B+i4B8ulmgVG671qWAEtwuWo5QRDKMSU+/wUf9XMdku6wcAcbyeaJb47j1lTFRnJFalsi2qSSM/HHyJlJObfyiszD8Z5v85qsa5BnVAisUy93mkp7YVNHFyNDjl1+85BmQlHi9psm4v7z8X3dCDYGPgNmKcJBStkICST42V2seg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562061; c=relaxed/simple; bh=X02XAkJ/qvwOROXqM6gNmWkrEK5vY8c0WEEa1+0hPmU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wtjny/4stYcT7YtyXI6W2MRKZZRyNRfhUM3NKhGJgLpHd7nTDeC3vYAblc5QxsGhuu7bpAi29fOdMeLqHYU4eUVfOdVgugCwHzghfIb85rBD6ij/z1XiStxmSdRn/COCxZ/r7UQNwGwFg8rxAYNlXUOPwfGdMGAG7pELBu8wSrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SZstAtL0; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SZstAtL0" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47f7444576cso991291f8f.0 for ; Mon, 20 Jul 2026 08:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562057; x=1785166857; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O7zJzFQDZ2ba/zKljTx71fkG4BHmnEG0mOPFGgp16IY=; b=SZstAtL0/nDkqNrMR2gYn1STZLTyrkJDSvQ+X+6XOxBUO7HwFi0vA6yIelsr5rpbGy aWF7TFVWt69Qv6xFhx+QnWKQk3IV/XLb6FmESMUvN2XuqIFR+JWyDRMQl6n1pmOT/VyR V2g5//hbg1dvI0mlaAOhSp80lH3l0J5sQwAdA7hfcbuG97D/5+rWiqtjlduKHg+T3qz6 rpAyAY8NkkjIb9vTk47BjtVLdsRuTqo9tBWEj/Nj+UkJTO6/2B7EC8B2Ly/TXXZwLJSM nnkKGNQdwDfDF0cQEgYkTQWTC0sbrAiudBFgF1ozKMEhw2vycuoxkq7v7MI64rohy+v6 6gyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562057; x=1785166857; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=O7zJzFQDZ2ba/zKljTx71fkG4BHmnEG0mOPFGgp16IY=; b=ZtLQQ171XSRWhYlJZHk+PeYwJ11ase/y9OKUji2lHaJVVY/jhBneQFCfsRL5JlXcVS VdA5Mn5sx/D23Of1QhbBOa7jh/yd3WPjo7WuE7eHZ5fRTkzf7jkp68Z4bPJFTWqVfXpA oCl85eFZenpb/LTT4xAMK6a3LPtu8UyBkpGLnHnAa0fvvvk18z1rIkiC4+lzKA4Tfrx2 cQTfb9TVg6UqToR7beuc7F7fSdSUBk7vRKsDcatjxTQKIKv4KnL5J7fd7dyrfODDFmYP FviIBCulBZcI/BS1hrbgPsfUQWOOvLEDFK0NXJsioqqJ3ntWt6zTHVuLB2QHTTZ8iJJT 1sZw== X-Forwarded-Encrypted: i=1; AHgh+RpfREIDyNPX8fR5S/8s1vX4C7519/JnRbOXTy6MoK9NP3axpIugKzgTIdevgIJfZpLSRIs=@lists.linux.dev X-Gm-Message-State: AOJu0Yz0pCI7jRC8EWmw1cIvagNDKUiYEOtRq7anZbmmkMGCJLE2D/RD /S7D/JofyrCF812UJuKxUzUDzzcoYvWVOnLWdCf4opArvAzGHT0M6Nxc X-Gm-Gg: AR+sD11tU9H8Byfx9i3n9ZXX8V7j2r1KvVIrRuUQFp5nCtERdJki9gOFdowQb5OxUGZ MxGZfVCQn+B7ia8ngycARKpAE+e4fZrzZQKtHdIxfhro3l+usgEDHC+eXZ8bKmqzGCAHIxRqaiQ wWVbj/B8kPtayCdPfwLjqaLrprhVke1aKfG0UR/00nt2zRrAFdaMrcf+/bjhYKENmCPU5rS/6RH 3vtiEKDATW6r00IMlPbX5+sjrRrWg/WW/S6ONKfJK2g3cTql8sccu/ycFNKil2hK8Aq0DWYSqV4 JpQpSm5l466j1/UMdRRcXjCAOGUsvQaLNt29ighPmycAVJbp3Am3gXa5UmqBkBPtCVFx1cuFXAT j0EE0UjaddFgqxnNWMxv7uNPErx6t2wBWLBAsHeKfWVmSur0TNV6+nwxAiWv9rVbRDh2xb8QpE5 b2BlNkZdGk6Q== X-Received: by 2002:a5d:6f02:0:b0:47f:7154:ab20 with SMTP id ffacd0b85a97d-47f7154ae17mr8536055f8f.37.1784562057410; Mon, 20 Jul 2026 08:40:57 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:40:56 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:35 +0200 Subject: [PATCH v2 03/15] drm/tegra: remove dependency on DRM simple helpers Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-3-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/tegra/dsi.c | 16 +++++++++++++--- drivers/gpu/drm/tegra/rgb.c | 15 +++++++++++++-- 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index e7fdd8c7ac12..3f818c195e9a 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -20,11 +20,11 @@ #include #include +#include #include #include #include #include -#include #include "dc.h" #include "drm.h" @@ -1055,6 +1055,10 @@ tegra_dsi_encoder_atomic_check(struct drm_encoder *encoder, return err; } +static const struct drm_encoder_funcs tegra_dsi_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs tegra_dsi_encoder_helper_funcs = { .disable = tegra_dsi_encoder_disable, .enable = tegra_dsi_encoder_enable, @@ -1078,8 +1082,14 @@ static int tegra_dsi_init(struct host1x_client *client) &tegra_dsi_connector_helper_funcs); dsi->output.connector.dpms = DRM_MODE_DPMS_OFF; - drm_simple_encoder_init(drm, &dsi->output.encoder, - DRM_MODE_ENCODER_DSI); + err = drm_encoder_init(drm, &dsi->output.encoder, + &tegra_dsi_encoder_funcs, + DRM_MODE_ENCODER_DSI, NULL); + if (err) { + drm_err(drm, "failed to initialize encoder: %d\n", err); + return err; + } + drm_encoder_helper_add(&dsi->output.encoder, &tegra_dsi_encoder_helper_funcs); diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c index e67fbb2362e6..bc1c93c7554c 100644 --- a/drivers/gpu/drm/tegra/rgb.c +++ b/drivers/gpu/drm/tegra/rgb.c @@ -9,7 +9,8 @@ #include #include -#include +#include +#include #include "drm.h" #include "dc.h" @@ -194,6 +195,10 @@ tegra_rgb_encoder_atomic_check(struct drm_encoder *encoder, return err; } +static const struct drm_encoder_funcs tegra_rgb_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs tegra_rgb_encoder_helper_funcs = { .disable = tegra_rgb_encoder_disable, .enable = tegra_rgb_encoder_enable, @@ -305,7 +310,13 @@ int tegra_dc_rgb_init(struct drm_device *drm, struct tegra_dc *dc) if (!dc->rgb) return -ENODEV; - drm_simple_encoder_init(drm, &output->encoder, DRM_MODE_ENCODER_LVDS); + err = drm_encoder_init(drm, &output->encoder, &tegra_rgb_encoder_funcs, + DRM_MODE_ENCODER_LVDS, NULL); + if (err) { + drm_err(drm, "failed to initialize encoder: %d\n", err); + return err; + } + drm_encoder_helper_add(&output->encoder, &tegra_rgb_encoder_helper_funcs); -- 2.54.0