From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50915434E43 for ; Mon, 20 Jul 2026 15:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562084; cv=none; b=Us1SmDTFFT5DYzqwgs5IfmTCw5M22wWAZ5+nkcUSl94cWA7FVXsq/1UW2DF9371AqBzL2haZFDpe7ZLhEhkS1aIVZeoJVoHUInXEZUBnBUlZyceCxco3BdlDiZAOo2aev1/yJH5SQ7i4cclHcmk1RgjNch3xMsPeO1OoEWJ8x2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562084; c=relaxed/simple; bh=xtpstExKIgCbeQEE7Wf+l6VvB9HewQ24E1EuTt+0AL4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fEnBLnBDVjRWJdaDWHNQuEXx8TI+BarA2jP5xf3WZ7mZGowYhX/bLW6bU4MqviFn3vrDEWZNJ67XTG7EyTLvusIOzHRe9gz/Pe3EilCjZ/i0yetIy5ap2aBRI0o7ihGR91noUF5tRd3aIcI+wuUjAxte++y0Q8wqbVEYxMuCqFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bzYdJ1BU; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bzYdJ1BU" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49548e01d02so14819335e9.0 for ; Mon, 20 Jul 2026 08:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562080; x=1785166880; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=o8dh5aQckfiP03vdZ5nRuu+LA2oP+sZO4zs8QLavR/M=; b=bzYdJ1BUUAX2tYFVLmCux1jpf7jPY/VWciMIcSpFGm9Hu9k6AnGzG9zwoDRdsN66KC ZP0/VHl6J5onJFrHKXi8yxrciOULHwa6rOFq8LuvtHuGaziVBUWycOi2WzE7U7kBpxGH FRA+yLb9JA5WoYSYKqn5vQiqK8X3/g/i8Gwp7aLZl0z0N+rxf8hHr/oRT3xrI+Ke9cna 0uaDm0BiftNBMR9CqrSiZNAu4RLs7TJklQsZS8KOSFhnjm3ArXL3GgO+iJsjBAxWGBSv IskBNyTsR/T/Y+3HRCQ9v93NZAr7jCQYZOladsJq4Hd3jBcg47gIBttYUcXAEk62cjlR YLgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562080; x=1785166880; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=o8dh5aQckfiP03vdZ5nRuu+LA2oP+sZO4zs8QLavR/M=; b=Ax2agWgRqC9eWlAPc5z9tHYp1MdVBPjWqfYYlx+ndIXwIZLR4xZK8icoOoPJ0pMx+N IVZR7xodNXQ5pYdGg9iI6aS18lKOQLUD+6Cd2s7pwlQpuq+x1o3VODWPlwFsit9MCJDB m5zXJetJ0V5MhT3DQhZll+dPCmYMmlJkFXBm9y7pNxG6IMyt4tLL7CA50boYObRMfrU8 asQTYrBM2wpR6z1wrhJw0QIYXMRU5GsEvC/EZwFB8Cxc5oS1j/oWwsxwJE07PaUsfdla c0gYT+rwrx1DAy4r/6d+JaLub31LlJ22J2z+hCqdRp8TsWCSHrtUGmj+XxqjOIlaWIJu D21w== X-Forwarded-Encrypted: i=1; AHgh+Ro69uHr7i2qvCAjuxOPXO78pXIi2ghK+cAIc3sN+LvynXzRA/Uopz76WJG/kO3TYwY2V0Y=@lists.linux.dev X-Gm-Message-State: AOJu0YzV4Md1/lVdtv5D8M4KyOtlOIkXxKZJck+d/rfuC5Tt7EggTj9B 96DUoz9rsCKx4wHgxUUTlR+ziTU8LAOPa2d1YE272G6LSzhwULPiVgT7 X-Gm-Gg: AfdE7cnWzq8gjVMGlaheWwNFBW5OPw2eJmReLveBDz88fLlH9bdxyv6BsohH/vYTXrB snQu8Ir+UgSFppjOZpT6S7mBdGfIO+bloXA5smtLPB07gYjjh+ORJJFXMwb8jzIB4KfdO1yC2SB KNJcCZYqHCB/kyULzp6QJaz10ZmlEqpd3WijBD7Nb49QQyhW6kMl220ps/eZG4Yndr3XXdx5Rx9 CLycQ9hdfy2wfm65ZX1/dO9O4+IIyVvvAG/AFJkYSwgXyw9LTINhjIMKOeqQ6B5CO5JMPyFPRo6 NJkkt30K7FDMH8Tpfno4ZxepC0hWl8vrxVcwsDWp+aBZf2QsedRfowwjYmMf20J35r8jtDvQ/kp xVTo06vSwiMfvfVKa4nBHDG2In/uq3+myMy6Pg4jAuQXtg6MCvL3w5eOjJi5sTtt3J7wXHwetaY vp35u2LX7V7g== X-Received: by 2002:a05:600c:524c:b0:495:4e12:6ae5 with SMTP id 5b1f17b1804b1-4954e126afamr155928515e9.26.1784562080376; Mon, 20 Jul 2026 08:41:20 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:41:19 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:41 +0200 Subject: [PATCH v2 09/15] drm/mediatek: remove dependency on DRM simple helpers Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-9-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Signed-off-by: Diogo Silva --- drivers/gpu/drm/mediatek/mtk_dsi.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 3f3f56eed3f9..7cd136bd9605 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -21,12 +21,12 @@ #include #include #include +#include #include #include #include #include #include -#include #include "mtk_ddp_comp.h" #include "mtk_disp_drv.h" @@ -913,12 +913,16 @@ void mtk_dsi_ddp_stop(struct device *dev) mtk_dsi_poweroff(dsi); } +static const struct drm_encoder_funcs mtk_dsi_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) { int ret; - ret = drm_simple_encoder_init(drm, &dsi->encoder, - DRM_MODE_ENCODER_DSI); + ret = drm_encoder_init(drm, &dsi->encoder, &mtk_dsi_encoder_funcs, + DRM_MODE_ENCODER_DSI, NULL); if (ret) { drm_err(drm, "Failed to encoder init to drm\n"); return ret; -- 2.54.0