Re: [PATCH v2 6/6] ASOC: Unify code style for platform_device_id arrays

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit introduces a style inconsistency by missing several small platform_device_id arrays during its mechanical refactoring, despite the commit message claiming to use a 'compact one-line style for small entries'.
--

--- Patch [6]: [PATCH v2 6/6] ASOC: Unify code style for platform_device_id arrays ---
commit 03434ab8a73c8818fd87d755c26c0b8e9e4f5807
Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

ASOC: Unify code style for platform_device_id arrays

This commit unifies the code style of platform_device_id arrays across
various ASoC drivers. It updates list terminators to use a single space and
attempts to use a compact one-line style for small entries.

[ ... ]

> diff --git a/sound/soc/intel/avs/boards/probe.c b/sound/soc/intel/avs/boards/probe.c
> index 73884f8a535ca..4053d14289b95 100644
> --- a/sound/soc/intel/avs/boards/probe.c
> +++ b/sound/soc/intel/avs/boards/probe.c
> @@ -64,7 +64,7 @@ static const struct platform_device_id avs_probe_mb_driver_ids[] = {
>  	{
>  		.name = "avs_probe_mb",
>  	},
> -	{},
> +	{ }

[Severity: Low]
This isn't a bug, but should this entry also use the compact one-line style
mentioned in the commit message? It seems like this array missed the single
line styling update that was applied to files like da7219.c.

>  };
>  MODULE_DEVICE_TABLE(platform, avs_probe_mb_driver_ids);

[ ... ]

> diff --git a/sound/soc/intel/avs/boards/rt274.c b/sound/soc/intel/avs/boards/rt274.c
> index a689f4c80867b..289f1230851f4 100644
> --- a/sound/soc/intel/avs/boards/rt274.c
> +++ b/sound/soc/intel/avs/boards/rt274.c
> @@ -261,7 +261,7 @@ static const struct platform_device_id avs_rt274_driver_ids[] = {
>  	{
>  		.name = "avs_rt274",
>  	},
> -	{},
> +	{ }

[Severity: Low]
This isn't a bug, but similar to the probe.c file above, should this entry
be compacted to a single line? There are several other files in this
directory (rt286.c, rt298.c, rt5514.c, etc.) that also seem to have missed
the compact one-line style update.

>  };
>  MODULE_DEVICE_TABLE(platform, avs_rt274_driver_ids);
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1784528081.git.u.kleine-koenig@baylibre.com?part=6