Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Joseph Guo" <qijian.guo@nxp.com>
Cc: devicetree@vger.kernel.org, Frank.Li@kernel.org,
	conor+dt@kernel.org, imx@lists.linux.dev, robh@kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: imx93: Add i.MX93 Wireless FRDM board support
Date: Thu, 23 Jul 2026 07:25:14 +0000	[thread overview]
Message-ID: <20260723072515.713B51F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260723-imx93w_frdm-v2-3-b108a76b2e40@nxp.com>

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The device tree fails to configure the Bluetooth reset and wake pins documented in the commit message, leaving the inherited Bluetooth node broken.
- [Low] The commit message contains a copy-paste error in its hardware differences table headers.
--

--- Patch [3]: [PATCH v2 3/3] arm64: dts: imx93: Add i.MX93 Wireless FRDM board support ---
commit 92706a692f2e24d9485918053962b1a10410a0ca
Author: Joseph Guo <qijian.guo@nxp.com>

arm64: dts: imx93: Add i.MX93 Wireless FRDM board support

This adds support for the i.MX93 Wireless FRDM board, reusing the
imx93-11x11-frdm-common.dtsi with board-specific changes. It updates pin
connections and functionality differences, mainly for WIFI/BT and I2C3.

> Pin connection differences:
> Function  Signal name   i.MX93W EVK             i.MX93 EVK

[Severity: Low]
This isn't a bug, but there's a copy-paste error in the table headers.
Should these be FRDM-IMX93W and FRDM-IMX93 instead of EVK?

[ ... ]

> diff --git a/arch/arm64/boot/dts/freescale/imx93w-frdm.dts b/arch/arm64/boot/dts/freescale/imx93w-frdm.dts
> new file mode 100644
> index 0000000000000..766e942fe6638
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx93w-frdm.dts
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2026 NXP
> + */
> +
> +/dts-v1/;
> +
> +#include "imx93w.dtsi"
> +#include "imx93-11x11-frdm-common.dtsi"
> +
> +/ {
> +	model = "NXP i.MX93W FRDM board";
> +	compatible = "fsl,imx93-wireless-frdm", "fsl,imx93";
> +};
> +
> +&iomuxc {
> +	pinctrl_lpi2c3: lpi2c3grp {
> +		fsl,pins = <
> +			MX93_PAD_GPIO_IO00__LPI2C3_SDA			0x40000b9e
> +			MX93_PAD_GPIO_IO01__LPI2C3_SCL			0x40000b9e
> +		>;
> +	};
> +};

[Severity: Medium]
Does this board-specific device tree need to include node overrides for
&bluetooth to configure the reset and wake pins documented in the commit
message?

The commit message notes that IND_RST_NB uses GPIO_IO28 (which was freed up
by rerouting I2C3), but there is no &bluetooth node override assigning it to
reset-gpios. Could this leave the inherited Bluetooth peripheral in reset
and broken?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723-imx93w_frdm-v2-0-b108a76b2e40@nxp.com?part=3

      reply	other threads:[~2026-07-23  7:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23  7:13 [PATCH v2 0/3] Add i.MX93 Wireless FRDM board support Joseph Guo
2026-07-23  7:13 ` [PATCH v2 1/3] arm64: dts: imx93-11x11-frdm: factor out common parts into dtsi Joseph Guo
2026-07-23  7:22   ` sashiko-bot
2026-07-23  7:13 ` [PATCH v2 2/3] dt-bindings: arm: fsl: Add i.MX93 Wireless FRDM board Joseph Guo
2026-07-23  7:13 ` [PATCH v2 3/3] arm64: dts: imx93: Add i.MX93 Wireless FRDM board support Joseph Guo
2026-07-23  7:25   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260723072515.713B51F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=qijian.guo@nxp.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox