From: sashiko-bot@kernel.org
To: "Francesco Dolcini" <francesco@dolcini.it>
Cc: Frank.Li@kernel.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v1 3/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Resistive Touch Display 7" Parallel
Date: Thu, 23 Jul 2026 11:11:19 +0000 [thread overview]
Message-ID: <20260723111119.D20AC1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260723105225.194366-4-francesco@dolcini.it>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The standalone device tree overlay `imx7d-colibri-emmc-panel-res-touch-7inch-parallel.dtbo` is omitted from the `dtb-$(CONFIG_SOC_IMX7D)` list in the Makefile, which prevents it from being installed by `make dtbs_install`.
--
--- Patch [3]: [PATCH v1 3/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Resistive Touch Display 7" Parallel ---
commit 0cb2a23058bf12eef57014cc393c2263436c395f
Author: Francesco Dolcini <francesco.dolcini@toradex.com>
ARM: dts: imx7d-colibri-emmc: Add Toradex Resistive Touch Display 7" Parallel
Add a device tree overlay for the Resistive Touch Display 7" Parallel
on the Colibri iMX7 parallel RGB LCD interface. The overlay is combined
with the Eval carrier board device tree to provide a ready-to-use DTB.
Link: https://developer.toradex.com/hardware/accessories/displays/resistive-touch-display-7inch-parallel/
> diff --git a/arch/arm/boot/dts/nxp/imx/Makefile b/arch/arm/boot/dts/nxp/imx/Makefile
> index 3c16843c30714..e9f95c3b83534 100644
> --- a/arch/arm/boot/dts/nxp/imx/Makefile
> +++ b/arch/arm/boot/dts/nxp/imx/Makefile
[ ... ]
> @@ -442,6 +446,7 @@ dtb-$(CONFIG_SOC_IMX7D) += \
> imx7d-colibri-emmc-iris-v2-panel-cap-touch-7inch-parallel.dtb \
> imx7d-colibri-emmc-eval-v3.dtb \
> imx7d-colibri-emmc-eval-v3-panel-cap-touch-7inch-parallel-touch-adapter.dtb \
> + imx7d-colibri-emmc-eval-v3-panel-res-touch-7inch-parallel.dtb \
[Severity: Medium]
Should the standalone device tree overlay
imx7d-colibri-emmc-panel-res-touch-7inch-parallel.dtbo also be added to
the dtb-$(CONFIG_SOC_IMX7D) list here?
It looks like omitting it prevents it from being installed by
make dtbs_install, which might break the ability to dynamically load
the overlay from a bootloader on other compatible carrier boards.
> imx7d-colibri-emmc-panel-cap-touch-7inch-parallel.dtbo \
> imx7d-colibri-eval-v3.dtb \
> imx7d-colibri-iris.dtb \
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260723105225.194366-1-francesco@dolcini.it?part=3
prev parent reply other threads:[~2026-07-23 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 10:52 [PATCH v1 0/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Displays 7" Parallel Francesco Dolcini
2026-07-23 10:52 ` [PATCH v1 1/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Capacitive Touch Display " Francesco Dolcini
2026-07-23 10:52 ` [PATCH v1 2/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Capacitive Touch Display 7" Parallel with Touch Adapter Francesco Dolcini
2026-07-23 11:09 ` sashiko-bot
2026-07-23 10:52 ` [PATCH v1 3/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Resistive Touch Display 7" Parallel Francesco Dolcini
2026-07-23 11:11 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723111119.D20AC1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=francesco@dolcini.it \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox