Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Marek Vasut" <marex@nabladev.com>
Cc: Frank.Li@kernel.org, robh@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v9 3/7] arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC
Date: Tue, 04 Aug 2026 16:42:11 +0000	[thread overview]
Message-ID: <20260804164211.8F87F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260804162310.24374-3-marex@nabladev.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Disabling a supply node without removing the consumer's `vin-supply` reference causes infinite probe deferral.
--

--- Patch [3]: [PATCH v9 3/7] arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC ---
commit 38e183a549e432bbb19f97500f860bf54f6c111a
Author: Marek Vasut <marex@nabladev.com>

arm64: dts: imx8mm: imx8mp: Add legacy board DTOs for Data Modul i.MX8M Mini and Plus eDM SBC

This commit adds legacy board revision compatibility DT overlays for both 
i.MX8M Mini and Plus eDM SBC boards. This adds adjustments to support 
legacy board revisions.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900.dtso b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900.dtso
> new file mode 100644
> index 0000000000000..427585b78e45d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc-overlay-edm-sbc-imx8mp-lvds-rev900.dtso

[ ... ]

> +&reg_panel_bl_supply {
> +	status = "disabled";
> +};
> +
> +&reg_panel_bl {
> +	gpio = <&gpio3 0 0>;
> +};

[Severity: High]
Will this cause an infinite probe deferral for the backlight?

The supply node reg_panel_bl_supply is being disabled here, but the consumer 
node reg_panel_bl inherits vin-supply = <&reg_panel_bl_supply>; from the 
base DT. 

Because the status property is ignored during phandle parsing, the regulator
framework will find the target node but fail to find a registered device for 
it, returning a permanent -EPROBE_DEFER. 

Should this also remove the reference via /delete-property/ vin-supply; in 
reg_panel_bl?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804162310.24374-1-marex@nabladev.com?part=3

  reply	other threads:[~2026-08-04 16:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 16:22 [PATCH v9 1/7] arm64: dts: imx8mp: Add DT label to SPBA5 bus Marek Vasut
2026-08-04 16:22 ` [PATCH v9 2/7] arm64: dts: imx8mm: imx8mp: Add LVDS DTOs for Data Modul i.MX8M Mini and Plus eDM SBC Marek Vasut
2026-08-04 16:37   ` sashiko-bot
2026-08-04 16:22 ` [PATCH v9 3/7] arm64: dts: imx8mm: imx8mp: Add legacy board " Marek Vasut
2026-08-04 16:42   ` sashiko-bot [this message]
2026-08-04 16:22 ` [PATCH v9 4/7] arm64: dts: imx8mm: imx8mp: Add HDMI " Marek Vasut
2026-08-04 16:22 ` [PATCH v9 5/7] arm64: dts: imx8mm: imx8mp: Add CM " Marek Vasut
2026-08-04 16:22 ` [PATCH v9 6/7] arm64: dts: imx8mm: imx8mp: Add FIO1 " Marek Vasut
2026-08-04 17:20   ` sashiko-bot
2026-08-04 16:22 ` [PATCH v9 7/7] arm64: dts: imx8mm: imx8mp: Add FIO1-Audio " Marek Vasut
2026-08-04 17:46   ` sashiko-bot
2026-08-06 20:10 ` [PATCH v9 1/7] arm64: dts: imx8mp: Add DT label to SPBA5 bus Frank.Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804164211.8F87F1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=marex@nabladev.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox