Re: [PATCH v3 1/4] dt-bindings: lcdif: Add endpoint bus-width property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree schema uses exact string matching (`properties: endpoint`) instead of pattern matching (`patternProperties`), failing to validate indexed endpoints with unit addresses (e.g., `endpoint@0`) and silently bypassing constraints for `bus-width`.
--

--- Patch [1]: [PATCH v3 1/4] dt-bindings: lcdif: Add endpoint bus-width property ---
commit 875819bc127ee9201c1b4dcfb35262deed8eb282
Author: Francesco Dolcini <francesco.dolcini@toradex.com>

dt-bindings: lcdif: Add endpoint bus-width property

This commit introduces a bus-width property to the output endpoint of the
LCDIF display binding. It allows configuring the DPI output with a bus
width of 16, 18, or 24 bits.

> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index 2dd0411ec6516..1f3daf0027075 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -71,6 +71,15 @@ properties:
>      $ref: /schemas/graph.yaml#/properties/port
>      description: The LCDIF output port
>  
> +    properties:
> +      endpoint:

[Severity: Medium]
Will this exact string match cause validation to be skipped for indexed
endpoints?

If a device tree defines an endpoint with a unit address under the port node,
such as endpoint@0 or endpoint@1, the exact match on endpoint bypasses
validation of the constraints inside this block. As a result, incorrect
bus-width values on indexed endpoints would silently pass validation.

Does this need to use patternProperties to correctly match both standard and
indexed endpoints?

> +        $ref: /schemas/media/video-interfaces.yaml
> +        unevaluatedProperties: false
> +
> +        properties:
> +          bus-width:
> +            enum: [ 16, 18, 24 ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260812132954.148571-1-francesco@dolcini.it?part=1