Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: andersson@kernel.org, konradybcio@kernel.org,
	dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v6 0/4] soc: qcom: ubwc: Fix link error when QCOM_SMEM=n
Date: Mon, 17 Aug 2026 11:17:43 -0700	[thread overview]
Message-ID: <20260817181743.GB1249844@ax162> (raw)
In-Reply-To: <20260817123542.48475-1-daniel.baluta@nxp.com>

Hi Daniel,

On Mon, Aug 17, 2026 at 03:35:37PM +0300, Daniel Baluta wrote:
> DRM_MSM and VIDEO_QCOM_IRIS select QCOM_UBWC_CONFIG, whose
> ubwc_config.c calls QCOM_SMEM APIs unconditionally. On configs without
> QCOM_SMEM this fails to link, e.g. on SOC_IMX5:
> 
>   arm-linux-gnueabihf-ld: ubwc_config.c:(.text+0x2c): undefined
>       reference to 'qcom_smem_is_available'
> 
> Fix it by making the QCOM_SMEM requirement explicit in Kconfig.
> 
> Changes since v5:
>  * added patch 4/4 to this series, which was initially sent as a
>  standalone patch (addresses review from Nathan)
>  * no other change to the series.
>  * picked up all R-b and Acked-by tags.
> 
> Link to v5: https://lore.kernel.org/imx/20260814141724.1006382-1-daniel.baluta@nxp.com/T/#t
> 
> Daniel Baluta (4):
>   drm/msm: Guard the QCOM_UBWC_CONFIG select with QCOM_SMEM
>   media: iris: Guard the QCOM_UBWC_CONFIG select with QCOM_SMEM
>   soc: qcom: ubwc: Fix link error when QCOM_SMEM=n
>   soc: qcom: ubwc: Fix missing include
> 
>  drivers/gpu/drm/msm/Kconfig              | 3 ++-
>  drivers/media/platform/qcom/iris/Kconfig | 3 ++-
>  drivers/soc/qcom/Kconfig                 | 1 +
>  include/linux/soc/qcom/ubwc.h            | 1 +
>  4 files changed, 6 insertions(+), 2 deletions(-)

Thanks, this resolves the build errors that I noticed.

Tested-by: Nathan Chancellor <nathan@kernel.org> # build

-- 
Cheers,
Nathan

      parent reply	other threads:[~2026-08-17 18:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 12:35 [PATCH v6 0/4] soc: qcom: ubwc: Fix link error when QCOM_SMEM=n Daniel Baluta
2026-08-17 12:35 ` [PATCH v6 1/4] drm/msm: Guard the QCOM_UBWC_CONFIG select with QCOM_SMEM Daniel Baluta
2026-08-17 12:41   ` sashiko-bot
2026-08-17 12:35 ` [PATCH v6 2/4] media: iris: " Daniel Baluta
2026-08-18  0:57   ` Dmitry Baryshkov
2026-08-18  0:58   ` Dmitry Baryshkov
2026-08-17 12:35 ` [PATCH v6 3/4] soc: qcom: ubwc: Fix link error when QCOM_SMEM=n Daniel Baluta
2026-08-18  1:02   ` Dmitry Baryshkov
2026-08-17 12:35 ` [PATCH v6 4/4] soc: qcom: ubwc: Fix missing include Daniel Baluta
2026-08-17 12:42   ` sashiko-bot
2026-08-17 18:17 ` Nathan Chancellor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260817181743.GB1249844@ax162 \
    --to=nathan@kernel.org \
    --cc=andersson@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=imx@lists.linux.dev \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox