From: sashiko-bot@kernel.org
To: "Pankaj Gupta" <pankaj.gupta@nxp.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
Frank.Li@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v37 1/7] Documentation/firmware: add imx/se to other_interfaces
Date: Wed, 19 Aug 2026 06:16:04 +0000 [thread overview]
Message-ID: <20260819061604.AA8081F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260819-imx-se-if-v37-1-5ef5de9ff1dc@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The kernel-doc directive references a non-existent file (`drivers/firmware/imx/se_ctrl.c`), which will cause Sphinx builds to fail or emit warnings.
--
--- Patch [1]: [PATCH v37 1/7] Documentation/firmware: add imx/se to other_interfaces ---
commit ac0ee8751fff1b6f43a912d3cdc22822ca9395fb
Author: Pankaj Gupta <pankaj.gupta@nxp.com>
Documentation/firmware: add imx/se to other_interfaces
This commit documents the i.MX SoC's Service layer and C_DEV driver for
selected SoCs containing NXP hardware IPs for Secure Enclaves.
> diff --git a/Documentation/driver-api/firmware/other_interfaces.rst b/Documentation/driver-api/firmware/other_interfaces.rst
> index 06ac89adaafba..6c6fa9a0ba1df 100644
> --- a/Documentation/driver-api/firmware/other_interfaces.rst
> +++ b/Documentation/driver-api/firmware/other_interfaces.rst
[ ... ]
> +When a user sends a command to the firmware, it registers its device_ctx
> +as waiter of a response from firmware.
> +
> +Enclave's Firmware owns the storage management over a Linux filesystem.
> +For this c_dev provisions a dedicated slave device called "receiver".
> +
> +.. kernel-doc:: drivers/firmware/imx/se_ctrl.c
> + :export:
[Severity: Low]
Does drivers/firmware/imx/se_ctrl.c exist at this point in the tree?
Referencing a non-existent file in a kernel-doc directive will cause the
Sphinx documentation build to emit warnings or fail.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260819-imx-se-if-v37-0-5ef5de9ff1dc@nxp.com?part=1
next prev parent reply other threads:[~2026-08-19 6:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 11:42 [PATCH v37 0/7] firmware: imx: driver for NXP secure-enclave Pankaj Gupta via B4 Relay
2026-08-19 11:42 ` [PATCH v37 1/7] Documentation/firmware: add imx/se to other_interfaces Pankaj Gupta via B4 Relay
2026-08-19 6:16 ` sashiko-bot [this message]
2026-08-19 11:42 ` [PATCH v37 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc Pankaj Gupta via B4 Relay
2026-08-19 11:42 ` [PATCH v37 3/7] firmware: imx: add driver for NXP EdgeLock Enclave Pankaj Gupta via B4 Relay
2026-08-19 6:23 ` sashiko-bot
2026-08-19 11:42 ` [PATCH v37 4/7] firmware: imx: device context dedicated to priv Pankaj Gupta via B4 Relay
2026-08-19 11:42 ` [PATCH v37 5/7] firmware: imx: adds miscdev Pankaj Gupta via B4 Relay
2026-08-19 6:27 ` sashiko-bot
2026-08-19 11:49 ` [EXT] " Pankaj Gupta
2026-08-19 11:42 ` [PATCH v37 6/7] arm64: dts: imx8ulp: add secure enclave node Pankaj Gupta via B4 Relay
2026-08-19 6:23 ` sashiko-bot
2026-08-19 11:42 ` [PATCH v37 7/7] arm64: dts: imx8ulp: add reserved memory for EdgeLock Enclave Pankaj Gupta via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819061604.AA8081F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=pankaj.gupta@nxp.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox