Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: pankaj.gupta@oss.nxp.com
Cc: Frank.Li@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, conor+dt@kernel.org
Subject: Re: [PATCH v39 6/7] arm64: dts: imx8ulp: add secure enclave node
Date: Fri, 21 Aug 2026 07:40:50 +0000	[thread overview]
Message-ID: <20260821074050.BD6291F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260821-imx-se-if-v39-6-41e4257c2afc@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `hsm0` node added to `imx8ulp.dtsi` lacks the `memory-region` property, which will cause `dtbs_check` schema validation to fail for any board that leaves the node disabled.
--

--- Patch [6]: [PATCH v39 6/7] arm64: dts: imx8ulp: add secure enclave node ---
commit 2df947c02e3ec38b8653aed8492f9d709b178160
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

arm64: dts: imx8ulp: add secure enclave node

This commit adds the EdgeLock Enclave (ELE) secure-enclave node to the
i.MX8ULP SoC dtsi. The node is kept disabled by default so it doesn't impose
a reserved-memory requirement on every board.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
[ ... ]
> @@ -185,6 +185,14 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +			status = "disabled";
> +		};

[Severity: Low]
Will this missing memory-region property cause dtbs_check schema validation
to fail for boards that leave the node disabled?

The DT schema fsl,imx-se.yaml requires the memory-region property for the
fsl,imx8ulp-se-ele-hsm compatible unconditionally. Because dt-validate
evaluates all nodes in the resulting DTB, including those with
status = "disabled", any board including imx8ulp.dtsi that does not enable
the enclave and provide a memory-region will trigger a validation warning.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260821-imx-se-if-v39-0-41e4257c2afc@nxp.com?part=6

  reply	other threads:[~2026-08-21  7:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 13:02 [PATCH v39 0/7] firmware: imx: driver for NXP secure-enclave pankaj.gupta
2026-08-21 13:02 ` [PATCH v39 1/7] Documentation/firmware: add imx/se to other_interfaces pankaj.gupta
2026-08-21  7:38   ` sashiko-bot
2026-08-21 13:02 ` [PATCH v39 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc pankaj.gupta
2026-08-21 13:02 ` [PATCH v39 3/7] firmware: imx: add driver for NXP EdgeLock Enclave pankaj.gupta
2026-08-21 13:02 ` [PATCH v39 4/7] firmware: imx: device context dedicated to priv pankaj.gupta
2026-08-21 13:02 ` [PATCH v39 5/7] firmware: imx: adds miscdev pankaj.gupta
2026-08-21  7:53   ` sashiko-bot
2026-08-21 12:42     ` Pankaj Gupta (OSS)
2026-08-21 13:02 ` [PATCH v39 6/7] arm64: dts: imx8ulp: add secure enclave node pankaj.gupta
2026-08-21  7:40   ` sashiko-bot [this message]
2026-08-21 13:02 ` [PATCH v39 7/7] arm64: dts: imx8ulp: add reserved memory for EdgeLock Enclave pankaj.gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260821074050.BD6291F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=pankaj.gupta@oss.nxp.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox