Re: [PATCH v3] PCI: imx6: fix resource leaks in probe error paths

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Endpoint setup failure permanently leaks host resources and ignores initialization errors from imx_pcie_host_init().
--

--- Patch [1]: [PATCH v3] PCI: imx6: fix resource leaks in probe error paths ---
commit a77762d63857f9ca84de44552a329e64c4d4176e
Author: hanzhijian <hanzhijian1991@gmail.com>

PCI: imx6: fix resource leaks in probe error paths

This commit fixes resource leaks in imx_pcie_probe() by introducing
imx_pcie_detach_pd() to properly release power domains and device links
when probing fails. It ensures these resources are cleaned up in reverse
order of acquisition.

Link: https://lore.kernel.org/all/20260822013640.182C01F000E9@smtp.kernel.org/

> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 39790e66b98dc..467006d839a60 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
[ ... ]
> @@ -1956,8 +1987,10 @@ static int imx_pcie_probe(struct platform_device *pdev)
>  		return ret;
>  
>  	ret = pci_pwrctrl_create_devices(dev);
> -	if (ret)
> +	if (ret) {
> +		imx_pcie_detach_pd(imx_pcie);
>  		return dev_err_probe(dev, ret, "failed to create pwrctrl devices\n");
> +	}
>  
>  	pci->use_parent_dt_ranges = true;
>  	if (imx_pcie->drvdata->mode == DW_PCIE_EP_TYPE) {

[Severity: High]
This is a pre-existing issue, but does imx_add_pcie_ep() leak host resources
on failure, and ignore initialization errors?

Looking at the implementation of imx_add_pcie_ep():

drivers/pci/controller/dwc/pci-imx6.c:imx_add_pcie_ep() {
	...
	imx_pcie_host_init(pp);
	...
	ret = dw_pcie_ep_init(ep);
	if (ret) {
		dev_err(dev, "failed to initialize endpoint\n");
		return ret;
	}
	...
}

The return value of imx_pcie_host_init() is completely ignored, meaning errors
during clock, regulator, or PHY state initialization aren't caught. If the
hardware fails to power on, the driver proceeds to initialize the endpoint
anyway.

Additionally, if dw_pcie_ep_init() fails, the function returns directly
without calling imx_pcie_host_exit(). Doesn't this bypass teardown and
permanently leak all acquired host resources?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824075512.3386898-1-hanzhijian1991@gmail.com?part=1