Re: [PATCH v1 1/1] media: dt-bindings: tc358743: Convert to YAML

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML conversion drops the explicit hardware constraint for `clock-lanes`, allowing invalid device tree configurations to pass validation.
--

commit bdd5e3e786c51b25dcbd6765b03cb6736dcbf134
Author: Frank Li <Frank.Li@nxp.com>

media: dt-bindings: tc358743: Convert to YAML

Convert the Toshiba TC358743 HDMI-RX to MIPI CSI2-TX bridge device
tree binding from txt to YAML format.

> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358743.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358743.txt
> deleted file mode 100644
> index 59102edcf01ea..0000000000000
> --- a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358743.txt
> +++ /dev/null

[ ... ]

> -Optional Properties:
> -
> -- reset-gpios: gpio phandle GPIO connected to the reset pin
> -- interrupts: GPIO connected to the interrupt pin
> -- data-lanes: should be <1 2 3 4> for four-lane operation,
> -	      or <1 2> for two-lane operation
> -- clock-lanes: should be <0>

[ ... ]

> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358743.yaml b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358743.yaml
> new file mode 100644
> index 0000000000000..29dd1d58f766f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358743.yaml

[ ... ]

> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    unevaluatedProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            oneOf:

[Severity: Medium]
Does this conversion drop the explicit hardware constraint for clock-lanes?

In the original .txt binding, clock-lanes was required to be <0>. Without
explicitly defining clock-lanes with const: 0 here in the endpoint properties,
an invalid device tree specifying a non-zero value for clock-lanes will
incorrectly pass schema validation. This happens because
unevaluatedProperties: false permits any value up to 8 as defined in the
referenced video-interfaces.yaml.

> +              - items:
> +                  - const: 1
> +                  - const: 2

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827160312.4113159-1-Frank.Li@oss.nxp.com?part=1