Re: [PATCH v43 6/7] arm64: dts: imx8ulp: add secure enclave node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing required 'memory-region' property causes dtbs_check warnings for boards not enabling the secure enclave.
--

commit 2106f9e7211e704a2695d4d64ea8d1fd6500e104
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

arm64: dts: imx8ulp: add secure enclave node

This commit adds the EdgeLock Enclave (ELE) secure-enclave node to the
i.MX8ULP SoC dtsi. It defaults to disabled so that boards must explicitly
opt-in to provide the required memory-region.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index 777b89ed68490..ac8293f81c6b2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi

[ ... ]

> @@ -186,6 +186,14 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +			status = "disabled";
> +		};

[Severity: Low]
Will adding the hsm0 node here without a memory-region property trigger a
dtbs_check warning for boards that do not enable it?

The commit message notes this is kept disabled to avoid imposing a
reserved-memory requirement on every board. However, the fsl,imx-se.yaml
dt-binding schema strictly requires the memory-region property unconditionally,
regardless of the node's status. 

Because of this, any board including imx8ulp.dtsi that does not include
imx8ulp-firmware.dtsi (or otherwise define the memory-region) might fail
validation during dtbs_check. 

Does the schema need to be relaxed to only require memory-region when
status is "okay", or is there a dummy region we should provide by default?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-imx-se-if-v43-0-a3deadbda4ef@nxp.com?part=6