Re: [PATCH 1/1] dt-bindings: mfd: da9052: allow dlg,da9053-aa fallback to dlg,da9052

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1939 bytes --]

On Mon, Aug 31, 2026 at 04:15:21PM -0400, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
> 
> Allow dlg,da9053-aa fallback to dlg,da9052 to fix legacy platform (> 10
> years) check_dtbs warnings:
>   arch/arm/boot/dts/nxp/imx/imx53-voipac-bsb.dtb: dialog@48 (dlg,da9053-aa): compatible: ['dlg,da9053-aa', 'dlg,da9052'] is too long
>         from schema $id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Previous try drop dlg,da9052 at
> https://lore.kernel.org/imx/20260404-thoughtful-placid-boobook-da26da@quoll/
> 
> but Krzy have concern about compablity.
> 
> https://lore.kernel.org/imx/20251107-matrimony-showdown-ba6ce6996b2f@spud/
> 
> Conor prefer update old dts.

I don't think these devices are actually compatible, so this fallback
would be wrong.
The data comes from the match data, be that spi or i2c, and there's
explicitly different behaviour for the da9052 and da9053aa.
I doubt the legacy platform ever worked properly, and this is what should
have been explained in the PR that Krzysztof denied not just blindly
citing a dtbs_check problem.

Nacked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/mfd/dlg,da9052.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
> index 1103a8cc5cea4..d1d23c7c4d0c2 100644
> --- a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
> +++ b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
> @@ -18,6 +18,10 @@ properties:
>            - dlg,da9053-bb
>            - dlg,da9053-bc
>            - dlg,da9052
> +      - items:
> +          - enum:
> +              - dlg,da9053-aa
> +          - const: dlg,da9052
>  
>    reg:
>      maxItems: 1
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]