From: sashiko-bot@kernel.org
To: pankaj.gupta@oss.nxp.com
Cc: imx@lists.linux.dev, Frank.Li@kernel.org, conor+dt@kernel.org,
robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v44 6/7] arm64: dts: imx8ulp: add secure enclave node
Date: Wed, 02 Sep 2026 06:48:25 +0000 [thread overview]
Message-ID: <20260902064826.63B4F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902-imx-se-if-v44-6-104658bf941a@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Commit message inaccuracy: mismatch between the SRAM node address in the commit message (`sram@2201f000`) and the actual node modified in the code (`sram@22010000`).
--
commit af8ee11fdbb0446f89343231545123f3615de2bf
Author: Pankaj Gupta <pankaj.gupta@nxp.com>
arm64: dts: imx8ulp: add secure enclave node
This commit adds the EdgeLock Enclave (ELE) secure-enclave node to the
i.MX8ULP SoC dtsi. It adds a label to the referenced SRAM node and keeps the
enclave node disabled by default to avoid imposing reserved-memory requirements
on all boards.
> Add the EdgeLock Enclave (ELE) secure-enclave node to the i.MX8ULP SoC
> dtsi, together with a label for sram@2201f000 that the node references.
[Severity: Low]
This isn't a bug, but there is a mismatch between the SRAM node address
mentioned here and the node modified in the code.
The commit message refers to sram@2201f000, while the code actually
labels and references sram@22010000. Should the commit message be updated
to match the modified device tree node?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-imx-se-if-v44-0-104658bf941a@nxp.com?part=6
next prev parent reply other threads:[~2026-09-02 6:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 12:08 [PATCH v44 0/7] firmware: imx: driver for NXP secure-enclave pankaj.gupta
2026-09-02 12:08 ` [PATCH v44 1/7] Documentation/firmware: add imx/se to other_interfaces pankaj.gupta
2026-09-02 12:08 ` [PATCH v44 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc pankaj.gupta
2026-09-02 12:08 ` [PATCH v44 3/7] firmware: imx: add driver for NXP EdgeLock Enclave pankaj.gupta
2026-09-02 12:08 ` [PATCH v44 4/7] firmware: imx: device context dedicated to priv pankaj.gupta
2026-09-02 12:08 ` [PATCH v44 5/7] firmware: imx: adds miscdev pankaj.gupta
2026-09-02 6:55 ` sashiko-bot
2026-09-02 8:53 ` Pankaj Gupta (OSS)
2026-09-02 12:08 ` [PATCH v44 6/7] arm64: dts: imx8ulp: add secure enclave node pankaj.gupta
2026-09-02 6:48 ` sashiko-bot [this message]
2026-09-02 12:08 ` [PATCH v44 7/7] arm64: dts: imx8ulp: add reserved memory for EdgeLock Enclave pankaj.gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902064826.63B4F1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=pankaj.gupta@oss.nxp.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox