Re: [PATCH v47 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Schema validation is incomplete because the new compatible string `fsl,imx95-se-ele-hsm` was omitted from the `if-then` conditional block for `memory-region`.
--

commit b55beebc71d9ffb0889e72c5f18c40a5edaa3652
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

dt-bindings: arm: fsl: add imx-se-fw binding doc

This commit introduces a new device tree binding document for NXP's Secure
Enclave hardware IP. It defines the required properties and conditional
constraints for communicating with the secure enclave firmware over message
units on various i.MX processors.

> diff --git a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml
> new file mode 100644
> index 0000000000000..fa81adbf9b80d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml

[ ... ]

> +allOf:
> +  # memory-region
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,imx8ulp-se-ele-hsm
> +              - fsl,imx93-se-ele-hsm

[Severity: Medium]
Should fsl,imx95-se-ele-hsm be included in this enum?

Since the else clause explicitly sets memory-region to false, any imx95
device tree defining a memory-region property will fail schema validation.
If the imx95 hardware requires a memory region like the previous generations
do, does it need to be added to this conditional block to prevent valid
configurations from failing and incomplete configurations from silently
passing validation?

> +    then:
> +      required:
> +        - memory-region
> +    else:
> +      properties:
> +        memory-region: false

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-imx-se-if-v47-0-b474ec6fc52a@nxp.com?part=2