From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19900511187 for ; Tue, 8 Sep 2026 09:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788858490; cv=none; b=oqMTbly2WzpJbNM6MyGj0pLXEKCD1HAxvs01zL8QrJp2Yc4cpVbzuSF54J+iHqauUhiHLkInLZv51JghDNSLaKZmTE/DSIsXbT6AWVvYqped2k8LgF5aiFvil+U5nuqsvYcMJCUhslEzcMzdiEn+ZpmvnOwymG1I3oZZiMfqrD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788858490; c=relaxed/simple; bh=xMbO6EhJUi/RdJ3ufWkeSaYG56Ls5TGr7006uLTOZQw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W1XqzOMCig/1dwFzaVHpoZ2QnPbdldSs/KrPafLEyeFD09IQnU9deUR8Fx4a0ph3ioLFV67ZmWFomDMSZWhbaU/pUZzru+m+i3BTqy+Odr9+coFhUF07+Xaj9kY410KHamrwI0XeQROaxpx2p6kIyIhZtruvkCqYLtO/8obi5Y0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=BnKwVQQo; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="BnKwVQQo" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-cc1c73645a1so3229577a12.1 for ; Tue, 08 Sep 2026 02:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1788858488; x=1789463288; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EZHoy8f3OpVjs16q22My2K8o0ZC/itaQqMauUbs1Www=; b=BnKwVQQoa/HkK5OZ1uv8EjB5FNgimdO1WyF42VKY7C7QE0pMdCSTu43wtKjWZm3zPU lSneFuLXqsLBj5jwGXF2YBHKdilNn37irr0ISfkmX33qsU9YDSSzyE+GgYiBlTwwYb74 byHVQrMWBFlOQW0o2gHmrdpdnKVITGOhfqqP8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788858488; x=1789463288; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=EZHoy8f3OpVjs16q22My2K8o0ZC/itaQqMauUbs1Www=; b=kbTduetXYalrpl3wl6n4C7fpIhEFhdgUb4bAmVLC5F04LJOYDEpKJXXC5lICqUG89M QJEUbKPgQDzPh4D7ZalLR4yvbV/cAnXWNT+uCao+oJDU/AgEGu7tml/qzMgzS9PCayw0 v2WBkmRy3247a6CdIGtPX7/SnxG7fjsKIPB2AsWCIsJaL8fLa7rk5WyWzM7NeMhAL7on U7s5ovvKsytYOSqj6Gyvz8nRcfzTcCSDCtPBPxZaSo0VWXY46EjkSL2cvLoSPBl+4HSD WOAB0JgB936aLi0Qa7F72UGuXrSo01pk28OslK6tTVzlpqu6fwHyg8b16htgSFMKZoLe daWQ== X-Forwarded-Encrypted: i=1; AKwUvBz+LeRhsA8Ws3z3n989Rogb6ZuU05RKPB1HJJXZiRLA7Mtu+116lkkpCn/8pIVal2G4Qic=@lists.linux.dev X-Gm-Message-State: AFuF++nKpuUiiADlaZB+yTwWlVPnTOAbWf/G07AjZkgjvWXlAfc74d9h OytXYWHb/Gk5tJ2HLMOSTBs52uNwDDpmU6i/HFWxTylmiel9Kz4U/pcJxn+M1Ty32A== X-Gm-Gg: AYBFou1EuJQvcEzSxsm8vJOV4BLtCzYGGCVOP8hnAX6GUQh+pk8bqFm/KCzcWYO3gam ftXZ6iiT9lvuhzt8apbCRLK8I4x343u4V2tmfXnH48xjqByU/Bzz7xqnx09FNwHpYwjJm8IuGJx 1Etu2K1jkl6BdV7h+6k5csNbNdPMYfPqwLoH8aynYMSd80o+onA+cI6H4YfYGAR+NiFE6ZnAaU7 o/0npxNonrfEAjY/MhnS3xfUIizk51ZU8391cCvELX4k7tHMMfx3hncrMhdGgfYYG/BU3mdZe4n /Ku9HL7F/+HvAtJh2qaG5OQ3gD4ma428kLGvFtLdmXWhY2+yNkT0JKXONROAqslN8GxgCymbzuo 2fLZnFSJ+PIWctgTGEYQDj2SDsTYX5rdGRv9R0Sq46aYhkZk2mghUDchKeC5lVoDmmfKoAtzObE Wa0HFUhqmXukfqaHHjEJWaF96efCVlR5lLA179D8VqnlQHjAtMj6cXJvqjfnco4nMyFudNSjAZP 3qR7dkDoZmM166T6fYzDV4nexHda5Tbbtu6rgwi0rYQr2hIMBn/sY5Udw== X-Received: by 2002:a17:90a:d003:b0:398:ba9e:75ff with SMTP id 98e67ed59e1d1-39b26273a40mr43384810a91.21.1788858488251; Tue, 08 Sep 2026 02:08:08 -0700 (PDT) Received: from wenst-7875.tpe.corp.google.com ([2a00:79e0:201d:8:e541:8c2f:4ce9:823a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b4b72f62esm19718804a91.5.2026.09.08.02.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 02:08:06 -0700 (PDT) From: Chen-Yu Tsai To: Liu Ying , Laurentiu Palcu , Lucas Stach , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: Chen-Yu Tsai , David Airlie , Simona Vetter , linux-sunxi@lists.linux.dev, imx@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 3/4] drm/imx/dc: plane: Switch to drm_fb_dma_get_gem_clipped_addr() Date: Tue, 8 Sep 2026 17:07:42 +0800 Message-ID: <20260908090745.1089143-4-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.979.g7e5102b832-goog In-Reply-To: <20260908090745.1089143-1-wenst@chromium.org> References: <20260908090745.1089143-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The hardware is programmed with clipped source and destination dimensions, but the framebuffer address is calculated using drm_fb_dma_get_gem_addr(), which uses the full source dimensions. This will not match the source offset if the top and/or left sides are clipped. Switch to the new drm_fb_dma_get_gem_clipped_addr(), which provides the buffer address starting at the clipped boundary. Fixes: 711a3b878366 ("drm/imx: Add i.MX8qxp Display Controller KMS") Cc: # Needs drm_fb_dma_get_gem_clipped_addr() Signed-off-by: Chen-Yu Tsai --- drivers/gpu/drm/imx/dc/dc-plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/dc/dc-plane.c b/drivers/gpu/drm/imx/dc/dc-plane.c index dea7404fe659..7bab75d5dedd 100644 --- a/drivers/gpu/drm/imx/dc/dc-plane.c +++ b/drivers/gpu/drm/imx/dc/dc-plane.c @@ -65,7 +65,7 @@ static int dc_plane_check_max_source_resolution(struct drm_plane_state *state) static int dc_plane_check_fb(struct drm_plane_state *state) { struct drm_framebuffer *fb = state->fb; - dma_addr_t baseaddr = drm_fb_dma_get_gem_addr(fb, state, 0); + dma_addr_t baseaddr = drm_fb_dma_get_gem_clipped_addr(fb, state, 0); /* base address alignment */ if (baseaddr & 0x3) { @@ -146,7 +146,7 @@ dc_plane_atomic_update(struct drm_plane *plane, struct drm_atomic_commit *state) src_w = drm_rect_width(&new_state->src) >> 16; src_h = drm_rect_height(&new_state->src) >> 16; - baseaddr = drm_fb_dma_get_gem_addr(fb, new_state, 0); + baseaddr = drm_fb_dma_get_gem_clipped_addr(fb, new_state, 0); fu_ops = dc_fu_get_ops(dplane->fu); -- 2.55.0.979.g7e5102b832-goog