From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAD54576EC0; Tue, 8 Sep 2026 15:55:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882948; cv=none; b=C/vwVHuYdSgdPE9Ma63C63eHHlDbL9n241njse+3Vxt3hcSSk63yo/JZYblc3aIDrpQEGqes8OhIK/1XWxDcCUA5RHQBpex61WyaFQ7J3yaUN/A07kynA8uSHgO9A1jaAbHcrKtN7jlTLOyOxlmEI+aRX/QvaSxyLnm5hYTCX8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788882948; c=relaxed/simple; bh=F0DsDXS0lzN38rT7ZqZWFaICyTFJepSpyBucwjnhVGc=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ola4mvPO5GA2duaV8vbgLDMCuMDV8HoSJm2hjfeTyWt/0wkeOUEO/c8epP3y88NvqZF7kWpG6bilbuT1jMC5ctq4nswwY85z3PKgKMeKYKIKWAl0Loag97q3nOV5L1GWbNmUxv5LjcdyzRQpB9I/XPG9KiXz0c84Xq0oBryiGSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kao9mFOk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kao9mFOk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DB8B1F00A3A; Tue, 8 Sep 2026 15:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788882946; bh=vH5T0YzgrnlgIgz7qtn6BIyvyPiswJhYOI0mr5Da2KY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Kao9mFOkCCfX2dLv3blyy5UmJ/DDb240RHC9VNU9iQR/OxwkZtM4jhDD9cE3Eh4JT TFoKF9X02z1dc95fW+67mv1YDzUyXJlr2O3fd1VcaubNfGvms5Ue2P3bDKTkiasVIw nKxW5+Tr8OGSWeQxU8fGafHlqhDIz4Nilj9N+FUgBbgVH61iWqN28Xsf6sBY0D8D/8 oJmDBbiBZ5LRg2umMSLXzwW3xM4FVo1GotO3BUrtES2MIJ4qFdy7uh9V7iZUyFlJN0 AXnlnyynKGAWnxugh7hoKn0hq97ZyfomWAIgRTNRPIB/ryJKVvOciEz+HDnPZj8WHP uqJ9ZEb2QHQ3g== From: sashiko-bot@kernel.org Subject: Re: [PATCH 02/13] ARM: remove footbridge Reply-To: sashiko-reviews@lists.linux.dev To: "Arnd Bergmann" Cc: dri-devel@lists.freedesktop.org, Frank.Li@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org In-Reply-To: <20260908152808.3928630-3-arnd@kernel.org> References: <20260908152808.3928630-1-arnd@kernel.org> <20260908152808.3928630-3-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 08 Sep 2026 15:55:45 +0000 Message-Id: <20260908155546.5DB8B1F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Medium] Dangling Kconfig dependencies and orphaned drivers reference rem= oved Footbridge/NetWinder symbols. - [Medium] Dead code blocks conditionally compiled for deleted architecture= s remain in core ARM files. -- commit 5927fe5f70523467f7f940a2a1678e08472c6f67 Author: Arnd Bergmann ARM: remove footbridge This commit removes the deprecated Footbridge platform, including the StrongARM EBSA285 and NetWinder machines. It deletes the associated architecture-specific Kconfig entries, makefiles, and source files. > diff --git a/arch/arm/kernel/atags_parse.c b/arch/arm/kernel/atags_parse.c > index 4ec591bde3dfa..9865ec7f90d98 100644 > --- a/arch/arm/kernel/atags_parse.c > +++ b/arch/arm/kernel/atags_parse.c > @@ -69,24 +69,6 @@ static int __init parse_tag_mem32(const struct tag *ta= g) > =20 > __tagtable(ATAG_MEM, parse_tag_mem32); > =20 > -#if defined(CONFIG_ARCH_FOOTBRIDGE) && defined(CONFIG_VGA_CONSOLE) > -static int __init parse_tag_videotext(const struct tag *tag) > -{ [ ... ] > -__tagtable(ATAG_VIDEOTEXT, parse_tag_videotext); > -#endif > - [Severity: Medium] Since this patch removes the footbridge architecture, should similar arch-specific dead code be removed from arch/arm/kernel/atags_compat.c as well? For example, build_tag_list() in that file still retains conditional blocks for the removed configurations: #ifdef CONFIG_ARCH_NETWINDER if (params->u1.s.nr_pages !=3D 0x02000 && ... #ifdef CONFIG_FOOTBRIDGE if (params->u1.s.mem_fclk_21285) { ... #ifdef CONFIG_ARCH_EBSA285 if (machine_is_ebsa285()) { > diff --git a/arch/arm/mach-footbridge/Kconfig b/arch/arm/mach-footbridge/= Kconfig > deleted file mode 100644 > index 96a74d447028d..0000000000000 > --- a/arch/arm/mach-footbridge/Kconfig > +++ /dev/null > @@ -1,57 +0,0 @@ [ ... ] > -config ARCH_NETWINDER > - bool "NetWinder" [ ... ] > -config FOOTBRIDGE > - def_bool y [Severity: Medium] By removing the FOOTBRIDGE and ARCH_NETWINDER configs here, what happens to the drivers in other subsystems that still depend on them?=20 For example, drivers/watchdog/Kconfig still contains dependencies like: config 21285_WATCHDOG depends on FOOTBRIDGE And drivers/char/Kconfig has symbols like DS1620, NWBUTTON, and NWFLASH that depend on ARCH_NETWINDER. Will these be left permanently unbuildable since their configurations are orphaned? Additionally, 977_WATCHDOG depends on: (FOOTBRIDGE && ARCH_NETWINDER) || (ARM && COMPILE_TEST) If someone builds with COMPILE_TEST, won't this driver try to build but fail due to missing headers? > diff --git a/arch/arm/include/asm/hardware/dec21285.h b/arch/arm/include/= asm/hardware/dec21285.h > deleted file mode 100644 > index 894f2a635cbbd..0000000000000 > --- a/arch/arm/include/asm/hardware/dec21285.h > +++ /dev/null [Severity: Medium] Will the removal of this header cause fatal build errors for the orphaned drivers mentioned above? For example, if compilation is attempted (such as with COMPILE_TEST), nwflash_init() in drivers/char/nwflash.c and serial21285_init() in=20 drivers/tty/serial/21285.c both still include . Does this patch need to remove those orphaned drivers as well to prevent build breakages? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260908152808.3928= 630-1-arnd@kernel.org?part=3D2