Re: [PATCH v4 3/3] arm64: dts: freescale: add Nodebox v3 CPU Module

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Ethernet PHY reset and interrupt lines are defined in GPIO controllers but not consumed by the PHY nodes.
--

commit 74f5aff92f5e16bafbb9e87c062e7805112769f9
Author: Vincent Jardin <vjardin@free.fr>

arm64: dts: freescale: add Nodebox v3 CPU Module

This commit adds the device tree for the Free Mobile Nodebox v3 CPU module
built around the NXP LX2160A SoC.

> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi
> new file mode 100644
> index 0000000000000..143b24d69d629
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi

[ ... ]

> +&emdio1 {
> +	status = "okay";
> +
> +	/* Microchip LAN8023 dual 10G PCS/retimer, Clause 45 only, one address per slice */
> +	lan8023_phy_s0: ethernet-phy@2 {
> +		compatible = "ethernet-phy-ieee802.3-c45";
> +		reg = <2>;
> +	};
> +
> +	lan8023_phy_s1: ethernet-phy@3 {
> +		compatible = "ethernet-phy-ieee802.3-c45";
> +		reg = <3>;
> +	};
> +
> +	rtl8211fd: ethernet-phy@6 {
> +		compatible = "ethernet-phy-id001c.c916";
> +		reg = <6>;
> +	};
> +};

[Severity: Medium]
Should these PHY nodes consume the reset and interrupt GPIOs defined elsewhere
in this device tree?

The lines "lan8023-mdint", "lan8023-rst", and "u1300-rtl8211fd-int#" are
explicitly defined in other GPIO controllers in this file. Without the
reset-gpios and interrupts properties in the PHY nodes, the PHY framework
cannot reset the hardware during probe (which can lead to initialization
failures if the PHY is left in an unknown state by the bootloader) and
silently falls back to polling mode for link state changes.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-for-upstream-nbxv3-dts-v4-0-2fd07d5575ab@free.fr?part=3