Re: [PATCH v2 7/9] arm64: dts: imx8mm-kontron: Add GPIO labels and comments

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Undocumented functional change in hardware pin configuration
--

commit d302aef127127e0c0034e70e30def7814e7b8ba2
Author: Oualid Derouiche <oualid.derouiche@kontron.de>

arm64: dts: imx8mm-kontron: Add GPIO labels and comments

Describe the GPIOs and their purpose using labels and comments.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts
> index 1f3d0577f10c9..72588af057d21 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts
[ ... ]
>  	pinctrl_gpio4: gpio4grp {
>  		fsl,pins = <
> -			MX8MM_IOMUXC_SAI1_TXD2_GPIO4_IO14		0x19
> -			MX8MM_IOMUXC_SAI1_TXD3_GPIO4_IO15		0x19
> +			/* CAN address DIP switches 1-4 */
> +			MX8MM_IOMUXC_SAI1_RXC_GPIO4_IO1			0x19 /* CAN_ADR0 */
> +			MX8MM_IOMUXC_SAI1_RXD2_GPIO4_IO4		0x19 /* CAN_ADR1 */
> +			MX8MM_IOMUXC_SAI1_RXD3_GPIO4_IO5		0x19 /* CAN_ADR2 */
> +			MX8MM_IOMUXC_SAI1_RXD4_GPIO4_IO6		0x19 /* CAN_ADR3 */

[Severity: Medium]
Does this code introduce an undocumented functional change to the hardware pin
configurations in pinctrl_gpio4?

The patch modifies pinctrl_gpio4 to actively configure four entirely new pins
(GPIO4_IO1, GPIO4_IO4, GPIO4_IO5, GPIO4_IO6) with the pad setting 0x19. Since
the &gpio4 node references this group, applying this patch alters the hardware
pin multiplexing state during boot.

The commit message strictly claims to 'Add GPIO labels and comments' and
'Describe the GPIOs and their purpose using labels and comments', implying no
functional behavioral changes.

Could the commit message be updated to describe this functional change, or
should these new pins be separated into their own patch?

> +			MX8MM_IOMUXC_SAI1_TXD2_GPIO4_IO14		0x19 /* DSI_MUX_SEL */
> +			MX8MM_IOMUXC_SAI1_TXD3_GPIO4_IO15		0x19 /* DSI_MUX_OE */
>  		>;
>  	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-upstreaming-v7-2-imx-dt-improvements-08-26-v2-0-8e12bc5f1f10@kontron.de?part=7