Re: [PATCH v7 3/3] arm64: dts: freescale: add Nodebox v3 CPU Module

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The LAN8023 Ethernet PHY reset line is defined in the GPIO line names but not consumed by the PHY or MDIO nodes.
--

commit 01a0f7e456eaf4c337c371a1a52bfa41e64a5e2b
Author: Vincent Jardin <vjardin@free.fr>

arm64: dts: freescale: add Nodebox v3 CPU Module

The Nodebox v3 is a Free Mobile CPU module built around the NXP
LX2160A (16x Cortex-A72, DPAA2).

> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi
> new file mode 100644
> index 0000000000000..9c5588a75cdd4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi

[ ... ]

> +&emdio1 {
> +	status = "okay";
> +
> +	/* Microchip LAN8023 dual 10G PCS/retimer, Clause 45 only, one address per slice */
> +	lan8023_phy_s0: ethernet-phy@2 {
> +		compatible = "ethernet-phy-ieee802.3-c45";
> +		reg = <2>;
> +	};
> +
> +	lan8023_phy_s1: ethernet-phy@3 {
> +		compatible = "ethernet-phy-ieee802.3-c45";
> +		reg = <3>;
> +	};

[Severity: Medium]
Will the kernel be able to assert the physical reset line for these PHYs
during probe?

The hardware description defines a physical reset line for the LAN8023
(lan8023-rst on the u800 GPIO expander), but neither the PHY nodes nor the
MDIO bus have a reset-gpios property assigned to consume it.

If the PHY is left in a bad state, such as after a warm reboot or driver
unbind/bind, it might fail to probe or exhibit unstable link behavior
without the reset line being asserted by the phylib framework.

[ ... ]

> +	u800: gpio@75 {
> +		compatible = "ti,tca9539";
> +		reg = <0x75>;
> +		#gpio-cells = <2>;
> +		#interrupt-cells = <2>;
> +		gpio-controller;
> +		gpio-line-names =
> +			"carrier-gpio0", "carrier-gpio1",
> +			"carrier-gpio2", "carrier-gpio3",
> +			"carrier-gpio4", "carrier-gpio5",
> +			"carrier-gpio6", "carrier-gpio7",
> +			"carrier-gpio8", "carrier-gpio9",
> +			"carrier-gpio10", "carrier-gpio11",
> +			"", "", "",
> +			"lan8023-rst";

[Severity: Medium]
Is this physical reset line intended to be consumed by the ethernet-phy
nodes on the emdio1 bus?

Since this GPIO is never mapped to a consumer in the device tree bindings,
the Linux phylib framework will ignore it.

> +		interrupt-controller;
> +		interrupt-parent = <&gpio2>;
> +		interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-for-upstream-nbxv3-dts-v7-0-373a142b08d5@free.fr?part=3