Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: Frank.Li@kernel.org, conor+dt@kernel.org, robh@kernel.org,
	imx@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/4] arm64: dts: freescale: imx95-15x15-frdm: remove some rmem regions
Date: Thu, 17 Sep 2026 18:26:45 +0000	[thread overview]
Message-ID: <20260917182645.EA17F1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917-memory-region-name-v4-3-260755920ebf@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: unused vdev1vring reserved memory regions left behind
--

commit 12514a7b6ba32d79be71a2b0cfb351fc1fe91f46
Author: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

arm64: dts: freescale: imx95-15x15-frdm: remove some rmem regions

This commit removes several unused remoteproc reserved memory regions from
the device tree. They will instead be added in a DT overlay.

> diff --git a/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts b/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts
> index 0f43e3be70589..f9b0e266754d6 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts
> @@ -188,16 +188,6 @@ linux_cma: linux,cma {
>  			linux,cma-default;
>  		};
>  
> -		vdev0vring0: memory@88000000 {
> -			reg = <0 0x88000000 0 0x8000>;
> -			no-map;
> -		};
> -
> -		vdev0vring1: memory@88008000 {
> -			reg = <0 0x88008000 0 0x8000>;
> -			no-map;
> -		};
> -
>  		vdev1vring0: memory@88010000 {
>  			reg = <0 0x88010000 0 0x8000>;
>  			no-map;
> @@ -208,17 +198,6 @@ vdev1vring1: memory@88018000 {
>  			no-map;
>  		};

[Severity: Low]
Were vdev1vring0 and vdev1vring1 intentionally left behind? The patch removes
vdev0vring0, vdev0vring1, vdevbuffer, and rsc_table, stating these remoteproc
regions will be added via overlay. Leaving vdev1vring0 and vdev1vring1 behind
unnecessarily reserves 64KB of physical memory that Linux cannot use.

>  
> -		vdevbuffer: memory@88020000 {
> -			compatible = "shared-dma-pool";
> -			reg = <0 0x88020000 0 0x100000>;
> -			no-map;
> -		};
> -
> -		rsc_table: memory@88220000 {
> -			reg = <0 0x88220000 0 0x1000>;
> -			no-map;
> -		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-memory-region-name-v4-0-260755920ebf@nxp.com?part=3

  reply	other threads:[~2026-09-17 18:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 18:19 [PATCH v4 0/4] remoteproc: imx_rpoc: use memory-region-names to avoid hidden ABI Frank.Li
2026-09-17 18:19 ` [PATCH v4 1/4] dt-bindings: remoteproc: imx_rproc: document " Frank.Li
2026-09-17 18:28   ` sashiko-bot
2026-10-09  3:16   ` Peng Fan
2026-09-17 18:19 ` [PATCH v4 2/4] remoteproc: imx_rpoc: use " Frank.Li
2026-10-09  3:17   ` Peng Fan
2026-09-17 18:19 ` [PATCH v4 3/4] arm64: dts: freescale: imx95-15x15-frdm: remove some rmem regions Frank.Li
2026-09-17 18:26   ` sashiko-bot [this message]
2026-10-09  3:19   ` Peng Fan
2026-09-17 18:19 ` [PATCH v4 4/4] arm64: dts: freescale: add DT overlay for MX95-15x15-FRDM RPMSG usage Frank.Li
2026-10-09  3:21   ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917182645.EA17F1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=Frank.Li@oss.nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox