From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Frank.Li@oss.nxp.com, "Eugen Hristev" <ehristev@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Daniel Lezcano" <daniel.lezcano@kernel.org>,
"Felix Gu" <ustc.gu@gmail.com>,
"Stepan Ionichev" <sozdayvek@gmail.com>,
"Shuvam Pandey" <shuvampandey1@gmail.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Piyush Patle" <piyushpatle228@gmail.com>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Giorgi Tchankvetadze" <giorgitchankvetadze1997@gmail.com>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Rob Herring (Arm)" <robh@kernel.org>,
"Pei Xiao" <xiaopei01@kylinos.cn>,
"Shi Hao" <i.shihao.999@gmail.com>,
"Kees Cook" <kees+treewide@kernel.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"open list:MICROCHIP SAMA5D2-COMPATIBLE ADC DRIVER"
<linux-iio@vger.kernel.org>,
"moderated list:ARM/Microchip (AT91) SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
imx@lists.linux.dev, vkoul@kernel.org
Subject: Re: [PATCH 1/1] iio: use dmaengine_get_dma_device() instead of chan->device->dev
Date: Mon, 21 Sep 2026 00:26:00 +0100 [thread overview]
Message-ID: <20260921002600.7c3d5630@jic23-hlaptop> (raw)
In-Reply-To: <aqzefLjkj6VrLR1b@ashevche-desk.local>
On Fri, 18 Sep 2026 09:47:24 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Thu, Sep 17, 2026 at 04:36:26PM -0400, Frank.Li@oss.nxp.com wrote:
>
> > Replace direct dma_chan::device::dev access with the proper
> > dmaengine_get_dma_device() accessor in IIO DMA consumers.
> >
> > chan->device->dev is not always the device used for DMA mapping.
> > Some DMA engines support per-channel IOMMU mappings, so different
> > channels may use different DMA devices. dmaengine_get_dma_device()
> > returns the correct device for each channel.
> >
> > This also prepares for making the DMA engine provider data structures
> > private. DMA consumers should not access DMA engine internals directly.
>
> ...
>
> > drivers/iio/adc/at91-sama5d2_adc.c | 9 ++++++---
> > drivers/iio/adc/nxp-sar-adc.c | 2 +-
> > drivers/iio/adc/stm32-adc.c | 10 ++++++----
> > drivers/iio/adc/stm32-dfsdm-adc.c | 4 ++--
> > drivers/iio/adc/ti_am335x_adc.c | 4 ++--
> > drivers/iio/buffer/industrialio-buffer-dmaengine.c | 5 +++--
>
> Strictly speaking this is two patches, one per ADC folder and the other against
> IIO core. But this one is not a big one, so up to Jonathan.
Agreed that would be ideal but I don't care enough for a v2!
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Applied to the testing branch of iio.git (material for next merge window)
That will turn up in linux-next once tests are done and I remember to push.
Thanks,
Jonathan
>
next prev parent reply other threads:[~2026-09-20 23:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 20:36 [PATCH 1/1] iio: use dmaengine_get_dma_device() instead of chan->device->dev Frank.Li
2026-09-18 6:47 ` Andy Shevchenko
2026-09-20 23:26 ` Jonathan Cameron [this message]
2026-09-18 17:54 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921002600.7c3d5630@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Frank.Li@oss.nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=daniel.lezcano@kernel.org \
--cc=dlechner@baylibre.com \
--cc=ehristev@kernel.org \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=i.shihao.999@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kees+treewide@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=nicolas.ferre@microchip.com \
--cc=nuno.sa@analog.com \
--cc=o-takashi@sakamocchi.jp \
--cc=olivier.moysan@foss.st.com \
--cc=piyushpatle228@gmail.com \
--cc=robh@kernel.org \
--cc=shuvampandey1@gmail.com \
--cc=sozdayvek@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=ustc.gu@gmail.com \
--cc=vkoul@kernel.org \
--cc=xiaopei01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox