From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CD0E2ED848; Mon, 21 Sep 2026 04:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789966337; cv=none; b=vFbgFjzeXRu9KPzAYQkV7qbp1AE4wnCfY+FdCiuP1CUWfS0uer62jKYw1v7TEdyInGGdXkl+WWAZw0D/DGs+y9PfgsB/zd/EQ3Cs6SrP92minI6QWrnpOCrSVvO5OHHoiP4clg48Fzr/hJBEwH3l06AF7iZOWMmuqfoVh6Xiiek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789966337; c=relaxed/simple; bh=8kMF8rBimaKR13vElBQ7E2iTbUTLoPrvjEkzyOHFPes=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tzCOq9xifbgXVEJ0Y1SQUBRy0vBtP/Rg+BW0l6dC73LlLTSnsFVwammiHdrp6GjVIR8r47ZPZcu5hm+NSBAJJ7usDZ1rdH4reaPjXdlFFkufW4LbEevpeVQXCt4BhgZCT5lwE76XOK/v+5JGQ8LF/oFRAuv9Q89rPoGJ8322Ado= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RhmmDOGz; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RhmmDOGz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789966336; x=1821502336; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8kMF8rBimaKR13vElBQ7E2iTbUTLoPrvjEkzyOHFPes=; b=RhmmDOGzHSXVJjXqUviNr23y5rliXwlBhjSGusvBpM5q4Si+Nt/BUn9X B73rjYhhZ/bxiynv2VOtN8kBARUVKcKqbLVoHV45FhRkoL/Y9bsePEoTk hmD4YGKhsS7UHitjGBddAWFxNRPJlalp+9zt9lTRNusEanV3rZVt8oyRs KMoAXHXLM7+QXvASWDZvF585LUcu90PglM5Lk7FOxnVSYogHEBOgb4dwB 8JZ/9CQ+XiUQNxfxpa2aQ/hNOGMZEGJXpYkErSnyd9iVzX5kdZV8vRsE5 zWeGtIol6HyFGLEtckqavLhOsPzg8qszX0IQKb3LqQRwfbE/mwrVvB/Fk A==; X-CSE-ConnectionGUID: VyFQR2+8RfCorbaLyULdbQ== X-CSE-MsgGUID: SJoTK18lQba05PP9d3nIwQ== X-IronPort-AV: E=McAfee;i="6800,10657,11911"; a="101051118" X-IronPort-AV: E=Sophos;i="6.27,114,1787036400"; d="scan'208";a="101051118" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2026 21:52:16 -0700 X-CSE-ConnectionGUID: MItRL1SEQU+PADvh8ZG6qg== X-CSE-MsgGUID: Ps6tTfHOTIKYy6/HtaSfWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,114,1787036400"; d="scan'208";a="271036526" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa006.fm.intel.com with ESMTP; 20 Sep 2026 21:52:09 -0700 Received: by black.igk.intel.com (Postfix, from userid 1001) id 020F299; Mon, 21 Sep 2026 06:51:55 +0200 (CEST) Date: Mon, 21 Sep 2026 06:51:55 +0200 From: Mika Westerberg To: Pawel Zalewski Cc: Andi Shyti , Mika Westerberg , Shyam Sundar S K , Elie Morisse , Benson Leung , Guenter Roeck , Andy Shevchenko , Wolfram Sang , Devyn Liu , Oleksij Rempel , Pengutronix Kernel Team , Frank Li , Sascha Hauer , Fabio Estevam , Binbin Zhou , Khalil Blaiech , Asmaa Mnebhi , Mukesh Kumar Savaliya , Viken Dadhaniya , Ard Biesheuvel , Laxman Dewangan , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Israel Cepeda , Hans de Goede , Sakari Ailus , Hans Hu , George Cherian , linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 2/2] i2c: busses: use named initializers for acpi_device_id Message-ID: <20260921045155.GL106095@black.igk.intel.com> References: <20260918-acpi-i2c-v1-0-caf4bea4886c@thegoodpenguin.co.uk> <20260918-acpi-i2c-v1-2-caf4bea4886c@thegoodpenguin.co.uk> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260918-acpi-i2c-v1-2-caf4bea4886c@thegoodpenguin.co.uk> On Fri, Sep 18, 2026 at 02:01:51PM +0100, Pawel Zalewski wrote: > Use a designated initializer for the acpi_device_id fields which makes the > code more readable and consistent with how lists are initialized in the > rest of the kernel code base. Also drop explicitly setting fields to 0 > where it is redundant. > > Unify the list terminator to have a single space between the brackets and > no trailing comma. > > Unify list item alignment to have a single space padding between the > brackets. > > Signed-off-by: Pawel Zalewski > --- > drivers/i2c/busses/i2c-amd-asf-plat.c | 2 +- > drivers/i2c/busses/i2c-amd-mp2-plat.c | 2 +- > drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +- > drivers/i2c/busses/i2c-designware-platdrv.c | 42 ++++++++++++++--------------- For i2c-dw: Acked-by: Mika Westerberg