From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: Frank.Li@kernel.org, wsa+renesas@sang-engineering.com,
imx@lists.linux.dev
Subject: Re: [PATCH v4 1/1] mmc: use dmaengine_get_dma_device() instead of chan->device->dev
Date: Wed, 23 Sep 2026 19:00:17 +0000 [thread overview]
Message-ID: <20260923190017.860931F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923184612.3583132-1-Frank.Li@oss.nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] kconfig: typo ARCHMXC silently disables MMC_SDHCI_OF_ESDHC on i.MX
--
commit 67d6306a04d821b30b7f3d5938329171b9db539b
Author: Frank Li <Frank.Li@nxp.com>
mmc: use dmaengine_get_dma_device() instead of chan->device->dev
This commit replaces direct accesses to chan->device->dev with the proper
dmaengine_get_dma_device() API across several MMC host drivers. This
ensures the correct device is used for DMA mapping, particularly for DMA
engines that support per-channel IOMMU mappings.
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 79bfc425e7c7c..a8d0e7be0fec2 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -214,7 +214,7 @@ config MMC_SDHCI_OF_AT91
> config MMC_SDHCI_OF_ESDHC
> tristate "SDHCI OF support for the Freescale eSDHC controller"
> depends on MMC_SDHCI_PLTFM
> - depends on PPC || ARCH_MXC || ARCH_LAYERSCAPE || COMPILE_TEST
> + depends on PPC || ARCHMXC || ARCH_LAYERSCAPE || COMPILE_TEST
[Severity: High]
Does this unintentionally break the dependency for i.MX platforms? The Kconfig
symbol ARCHMXC does not appear to exist, whereas ARCH_MXC was used previously.
This could silently disable the driver on i.MX builds.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923184612.3583132-1-Frank.Li@oss.nxp.com?part=1
prev parent reply other threads:[~2026-09-23 19:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 18:45 [PATCH v4 1/1] mmc: use dmaengine_get_dma_device() instead of chan->device->dev Frank.Li
2026-09-23 18:50 ` Frank Li
2026-09-23 18:57 ` Arnd Bergmann
2026-09-23 19:33 ` Frank Li
2026-09-23 21:40 ` Frank Li
2026-09-23 23:01 ` Arnd Bergmann
2026-09-23 19:00 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923190017.860931F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox