Re: [PATCH v2] pmdomain: imx: gpc: remove all initialized power domains

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] imx_gpc_remove: syntax error due to missing closing brace
--

commit 8c74b27165f06b794b40a774855d31374a0b317d
Author: Guangshuo Li <lgs201920130244@gmail.com>

pmdomain: imx: gpc: remove all initialized power domains

This commit updates imx_gpc_remove() to use match data to iterate
and remove all initialized power domains in reverse order. It also
ensures the PU clocks are released when the PU domain is removed.

> diff --git a/drivers/pmdomain/imx/gpc.c b/drivers/pmdomain/imx/gpc.c
> index abca5f449a226..d83fb37e22974 100644
> --- a/drivers/pmdomain/imx/gpc.c
> +++ b/drivers/pmdomain/imx/gpc.c

[ ... ]

> @@ -519,20 +521,23 @@ static void imx_gpc_remove(struct platform_device *pdev)
>  	if (!pgc_node) {
>  		of_genpd_del_provider(pdev->dev.of_node);

[ ... ]

> +		num_domains = of_id_data->num_domains;
> +		while (num_domains--) {
> +			ret = pm_genpd_remove(&imx_gpc_domains[num_domains].base);
> +			if (ret) {
> +				dev_err(&pdev->dev,
> +					"Failed to remove %s power domain (%pe)\n",
> +					imx_gpc_domains[num_domains].base.name,
> +					ERR_PTR(ret));
> +				return;
> +			}
> +
> +		if (num_domains == GPC_PGC_DOMAIN_PU)
> +			imx_pgc_put_clocks(&imx_gpc_domains[num_domains]);
>  	}

[Severity: Low]
Is this while loop missing a closing brace?

Because there is no closing brace added for the new while loop, it appears
the closing brace at the end of this block will close the while loop instead
of the outer if (!pgc_node) statement. Will this cause unbalanced braces
and a build failure?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924142520.1594149-1-lgs201920130244@gmail.com?part=1