From: sashiko-bot@kernel.org
To: "Petko Manolov" <petko.manolov@konsulko.com>
Cc: devicetree@vger.kernel.org, Frank.Li@kernel.org,
imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board
Date: Tue, 29 Sep 2026 09:24:53 +0000 [thread overview]
Message-ID: <20260929092454.049FA1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260929091811.3735201-2-petko.manolov@konsulko.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing vendor prefix 'draeger' in registry
--
commit 023f077ed12c923bbdeea3fb8737b7678f238fe6
Author: Petko Manolov <petko.manolov@konsulko.com>
dt-bindings: arm: fsl: add Draeger M48 dual-cpu board
This commit adds device tree bindings for the Draeger M48 dual-cpu board.
It registers compatible strings for both the imx6q and imx6dl variants
used on the board.
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 656f2596e1d53..8f3a04228780a 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -260,6 +260,7 @@ properties:
> - boundary,imx6q-nitrogen6x
> - compulab,cm-fx6 # CompuLab CM-FX6
> - dmo,imx6q-edmqmx6 # Data Modul eDM-QMX6 Board
> + - draeger,imx6q-m48 # Draeger imx6q variant of M48
[Severity: Low]
Looking at the properties definition in
Documentation/devicetree/bindings/arm/fsl.yaml, is the new vendor prefix
'draeger' missing an entry in the vendor prefix registry?
If 'draeger' is not documented in vendor-prefixes.yaml, building the device
tree schemas will trip a missing reference, and schema validation via
dt_binding_check will report an undocumented vendor prefix error.
> - ds,imx6q-sbc # Da Sheng COM-9XX Modules
> - embest,imx6q-marsboard # Embest MarS Board i.MX6Dual
> - emtrion,emcon-mx6 # emCON-MX6D or emCON-MX6Q SoM
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260929091811.3735201-1-petko.manolov@konsulko.com?part=1
next prev parent reply other threads:[~2026-09-29 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 9:18 [PATCH v2 0/2] arm: dts: nxp: imx: add Draeger M48 CPU board Petko Manolov
2026-09-29 9:18 ` [PATCH v2 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board Petko Manolov
2026-09-29 9:24 ` sashiko-bot [this message]
2026-09-29 9:18 ` [PATCH v2 2/2] arm: dts: nxp: imx: Add devicetree files for M48 Petko Manolov
2026-09-29 9:34 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929092454.049FA1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=petko.manolov@konsulko.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox