Re: [PATCH v2 1/3] dt-bindings: dma: fsl,edma: add per-channel child node support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: fsl,edma: missing required interrupts property validation
--

commit 4f1b5be8631d1a7b37208c50010390f6dfaf3925
Author: Peng Fan <peng.fan@nxp.com>

dt-bindings: dma: fsl,edma: add per-channel child node support

Add support for optional per-channel child nodes to the fsl,edma binding
to describe real per-channel MMIO regions. The interrupts property is
removed from the required list to accommodate these child nodes.

> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index f609038e35ae1..19a103baccaf4 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
[ ... ]
> +patternProperties:
> +  "^dma-channel@[0-9a-f]+$":
> +    type: object
> +    additionalProperties: false
> +
> +    properties:
> +      reg:
> +        maxItems: 1
> +        description: Per-channel register region within the eDMA block.
> +
> +      interrupts:
> +        maxItems: 1
> +
> +      iommus:
> +        maxItems: 1
> +
> +      power-domains:
> +        maxItems: 1
> +
> +    required:
> +      - reg

[Severity: Medium]
Does this required list fail to enforce the interrupts property when the
new child node approach is used?

>  required:
>    - "#dma-cells"
>    - compatible
>    - reg
> -  - interrupts
>    - dma-channels

[Severity: Medium]
Does removing the interrupts property from the global required list break
schema validation for legacy device trees (e.g., fsl,vf610-edma or
fsl,imx7ulp-edma)?

Without this enforcement, invalid device trees that completely omit
interrupts might silently pass make dtbs_check. This could result in
incomplete device trees failing at runtime during driver probe. Is it
possible to preserve this in a conditional enforcement block for legacy
hardware instead of dropping it entirely?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-edma-iommu-v2-0-72a62bf44c74@nxp.com?part=1