From: sashiko-bot@kernel.org
To: "Primoz Fiser" <primoz.fiser@norik.com>
Cc: robh@kernel.org, Frank.Li@kernel.org, imx@lists.linux.dev,
conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals
Date: Wed, 30 Sep 2026 10:40:06 +0000 [thread overview]
Message-ID: <20260930104006.EC64F1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260930103425.2315286-2-primoz.fiser@norik.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: imx6dl-phytec-mira: missing m25p80 SPI NOR flash enablement
--
commit 1324c8cd36593c2b5134e1d0d30d31d809ac1bc1
Author: Primoz Fiser <primoz.fiser@norik.com>
ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals
This commit syncs the i.MX6 DL NAND variant device tree to match the Full
Featured (FF) variants. It enables peripherals including CAN and PCIe, and
removes the speed limit on the Ethernet PHY.
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts
> index d906a7f05aaad..1f827ad2ff5ee 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts
[ ... ]
> @@ -50,6 +50,10 @@ &i2c_rtc {
> status = "okay";
> };
>
> +&pcie {
> + status = "okay";
> +};
> +
[Severity: Medium]
Did this omit the SPI NOR flash enablement?
The commit message states the intent to sync the i.MX6 DL NAND variant to
match the Full Featured (FF) boards by enabling all peripherals.
The FF Quad variant (imx6q-phytec-mira-rdk-nand.dts) enables the SPI NOR flash
by including &m25p80 { status = "okay"; };. While &can1, &pcie, and the
unrestricted ðphy are enabled, the &m25p80 node is missing here.
Does this leave the board missing its SPI flash feature and partially
unsynchronized compared to the other FF variants?
> &uart3 {
> status = "okay";
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930103425.2315286-1-primoz.fiser@norik.com?part=1
next prev parent reply other threads:[~2026-09-30 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 10:34 [PATCH 0/2] ARM: dts: imx6: phytec-mira: phyBOARD-Mira fixes Primoz Fiser
2026-09-30 10:34 ` [PATCH 1/2] ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals Primoz Fiser
2026-09-30 10:40 ` sashiko-bot [this message]
2026-09-30 13:51 ` Primoz Fiser
2026-09-30 10:34 ` [PATCH 2/2] ARM: dts: imx6qdl-phytec-mira: Add touchscreen-inverted properties Primoz Fiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930104006.EC64F1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=primoz.fiser@norik.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox