Re: [PATCH v2 1/2] spi: use dmaengine public API instead of raw ops

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dmaengine: commit message falsely claims dma_async_issue_pending provides locking and debug checks
--

commit c24ebb64bdaa5d560933be18b6d65ba2f18df08e
Author: Frank Li <Frank.Li@nxp.com>

spi: use dmaengine public API instead of raw ops

This patch replaces direct calls to the internal DMA device ops
with the public dma_async_issue_pending() wrapper in the at91-usart
and atmel SPI drivers.

> Replace direct calls to the internal DMA device ops
> device->device_issue_pending() with the proper public DMA engine wrappers:
> dma_async_issue_pending().
> 
> Drivers must not call device ops directly; the wrappers provide locking,
> debug checks, and a stable interface that hides internal implementation
> details of the DMA controller driver.

[Severity: Medium]
Is this description of the wrapper accurate?

Looking at the implementation of dma_async_issue_pending() in
include/linux/dmaengine.h, it appears to be a direct inline call:

static inline void dma_async_issue_pending(struct dma_chan *chan)
{
        chan->device->device_issue_pending(chan);
}

Since this function directly calls the device ops without taking any locks
or performing additional debug checks, could the commit message be updated
to accurately reflect the actual semantics of the wrapper?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930140257.490019-1-Frank.Li@oss.nxp.com?part=1