Re: [PATCH v3 1/5] dmaengine: add dmaengine_prep_dma_(pq|pq_val|interrupt|xor)() API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] doc: incorrect flag names in dmaengine_prep_dma_pq_val() comment
--

commit f5c4a27207edbbbf16dc41d215bb04c300d1dd66
Author: Frank Li <Frank.Li@nxp.com>

dmaengine: add dmaengine_prep_dma_(pq|pq_val|interrupt|xor)() API

This commit adds inline wrappers for several DMA engine preparation
functions to provide a clean public API. It also incorporates proper
pointer checks before accessing the underlying device callbacks.

> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index c3a49a33307c6..6a187136f9493 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h

[ ... ]

> +/**
> + * dmaengine_prep_dma_pq_val - prepare a DMA PQ validation operation
> + * @chan: the channel to use for this operation
> + * @pq: array of two addresses holding existing P and Q parity buffers
> + * @src: array of source buffer addresses
> + * @src_cnt: number of source buffers
> + * @scf: array of scaling coefficients, one per source buffer
> + * @len: length in bytes of each buffer
> + * @pqres: output flags indicating P and/or Q check results (SUM_CHECK_P_VALID,
> + *         SUM_CHECK_Q_VALID)

[Severity: Low]
This isn't a bug, but the documentation refers to non-existent constants.
Should this instead reference the correct SUM_CHECK_P_RESULT and
SUM_CHECK_Q_RESULT flags?

> + * @flags: DMA engine flags (e.g. DMA_PREP_INTERRUPT)
> + *
> + * Prepare a PQ validation transaction.  The engine recomputes P and Q from the

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005-dmaengine_prep_dma_pq-v3-0-a4a241f26fa7@nxp.com?part=1