From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AFA2497B62 for ; Thu, 8 Oct 2026 10:42:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456143; cv=none; b=VaDvY9ICfMk526z/j6jjPbbVF9uITWm2QWjb+eGe0VkDcDmpeYwDPSYpq/OAnfmI04ewF9bPo5WpfLM1v7IgvUTskUEgSfdF75WQ8ZpXzW9MwHQ0vhr5jfPzZmArBCP0Wl67Fek+sunHwmF0ElULxwdQ/4F7AhSDgcncbkVd+eA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456143; c=relaxed/simple; bh=6dFh3KYbxtITJpRD4kNPYQg713kSVg+CYVFiW9/LyIQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GWBMRg4JROvqPJWAtn+qEqqsuHKKKW9RmUSdZ393z9Ig0LByHrfL4MqpxlcfnVEq0PsGJuuvvffjuXfzmv27ZVSYOJM2EW8jQXGNXtqdoGxo0FvGXHOzPtdTkWzZVB6dSWoPdl9Px8lnPSE1nuFK35qxWnN/ATqphLE8UbBEzfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XdUQ9DDL; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XdUQ9DDL" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-15943c9c005so1850522c88.1 for ; Thu, 08 Oct 2026 03:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456139; x=1792060939; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=p0qhtd+efK/Hc1Em0lvih3vUFvGAfNajebBLWEpeLzs=; b=XdUQ9DDLau+pU/zptkURmzu8Oq7o7Bh8PwsOkx0yeKcSUhtJuva0yX/SEIoF6Wtn/V aDsoDgyxMyAhp63pGsySQ0W9Q6QEn+/s5xLR3AuhH/k3LBYrK9DBjvPJMOT5kTnIbe3F 5MpStSQXeh2iwNvpd0zaTURymZ/f0y9UqJcWQDz6XaAKCzB+lv7kCiGqHcmOWKkUUHGr po8n908bZtGBnws3FEhPSYOyA2Fw6ImTd+T5N+jyjwkn/tnXcfbkXR0AA5xdFqsONdE3 8TnHBgzpKRVTGbOtb0IDT4u+UTKcctLe25UAVZ1bZzo2FOPu3aqQ0b9OaPWa6X0nqI3M gnFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456139; x=1792060939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=p0qhtd+efK/Hc1Em0lvih3vUFvGAfNajebBLWEpeLzs=; b=i4ZE+uRZ0PegjMAmdCxtL1CaGVizypvVzJe1tHp+KWoux+uXdxU0e2JHshBdmAnHM8 m/CRyofbobaUEEgZSTsQOMJguuqVo+esO2lP/HA4hx45CkcSbFDPVd730IffTKl80HCu II2sX0GLfbBlLQi1AxbSKpd9Y9gLhypOvDPH4VAJZuvoT+MR69IU+bCF3uI4ClQ/azYy uyqXseRInQB7L4BlDg2U+LMvIK4DTq1V+Tm1UxWM9INFgDnJCszzJwThYKOmFyE6HdB8 sGv9RVXsqUH607sMSa8MYvraStJRsEGvJ2eO2+5tsMKyx+XWgbWEzXNxqtRS6y/IFvH4 aikg== X-Forwarded-Encrypted: i=1; AKwUvBxh7CVDVqzYEmG0BBmL5mqLmLP758cv5CadPfktMkrNcxkuGojWmwiALjasWeMn79oFy7c=@lists.linux.dev X-Gm-Message-State: AFuF++l4JSjSZqd3GTpqbJCnyg75uONrudlFl8Eb5uhpxkhmXxp32+NH Z9EZ1GoqGcM2GJV4Q/3GCrJvrsF32dMIVdeRLRRJk2FNNwOWAMWyClPs X-Gm-Gg: AYBFou0efj1BjkkACKUEWz2YRgmHx7c/yJh83VVJGfHo5ecpu8TnjTQEjEQhcxS8Org vYXSSVSbxKN5RkMCCvNra7nCLuJQm31YdPYXI+U01eb54RQbaRGBNfc7wtqHWkZPnLFAZDkzteA 6y9FJEEELb2UcsGnG9/fiKoUGHw/x/Eyq46AGbt6mQw9X6Kf29HakYsbAFUVuN1As03uYqDNgA3 WbvZJuojuKAkZXTc882M5NQl9ic4KScQum19ZudqH/xTzmOsHcC3SZoJJXbJK7ulQACShReBsNZ ZRW8A2L9hxjNcfa+EgNTnh6FOIVo2vFtYI2/Fl6+uJrShSjm4Tf+ddp5k3Yd/kaWA8T14AqO2FL GGh1hg7CZTnn4VCPlQBYp/q4iSXH8qiQvVvcuHG2n1gPZeEzHK3mXJXIOOPdpf+dFmOel/t+rws 8atnfkF/m/K8Fz9AAWC9lRGXB7a94Tmq8SDlVB4k7cxYr8fyz+Q9NsZhB4FwibV3Zci5R4GRAaN a0dypJRuT10kTQauM6KMi35MPqvcu8nT3GWbxznniGlhTRTC2GQxEaw5LIIp9mb2iQ1ljkVy0Fs jLZtu3b6k/jNTc0= X-Received: by 2002:a05:701b:4501:10b0:15f:6789:2c2a with SMTP id a92af1059eb24-16207d7c2a4mr5290246c88.36.1791456139402; Thu, 08 Oct 2026 03:42:19 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:42:18 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 13/24] ASoC: codecs: nau8821: Ensure the DAI is marked as started on success Date: Thu, 8 Oct 2026 17:38:20 +0700 Message-ID: <20261008103831.542533-14-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from nau8821_dai_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as nau8821_dai_ops has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/nau8821.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c index ecadbaee1037..935df063822c 100644 --- a/sound/soc/codecs/nau8821.c +++ b/sound/soc/codecs/nau8821.c @@ -829,14 +829,19 @@ static int nau8821_dai_startup(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component); const struct nau8821_osr_attr *osr; + int ret; osr = nau8821_get_osr(nau8821, substream->stream); if (!osr || !osr->osr) return -EINVAL; - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_RATE, - 0, CLK_DA_AD_MAX / osr->osr); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_RATE, + 0, CLK_DA_AD_MAX / osr->osr); + if (ret < 0) + return ret; + + return 0; } static int nau8821_hw_params(struct snd_pcm_substream *substream, -- 2.43.0