From: Simon Horman <horms@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Frank.Li@oss.nxp.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Frank Li <Frank.Li@nxp.com>, Yicong Hui <yiconghui@gmail.com>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH 1/1] net: ethernet: micrel: ks8842: use dmaengine_submit() instead of ->tx_submit()
Date: Fri, 9 Oct 2026 11:36:22 +0100 [thread overview]
Message-ID: <20261009103622.GY83879@horms.kernel.org> (raw)
In-Reply-To: <asZhHwzXU1sdk3TH@parshuram>
On Wed, Oct 07, 2026 at 05:11:27PM +0200, Vinod Koul wrote:
> On 07-10-26, 15:43, Simon Horman wrote:
> > On Fri, Oct 02, 2026 at 03:30:19PM -0400, Frank.Li@oss.nxp.com wrote:
> > > From: Frank Li <Frank.Li@nxp.com>
> > >
> > > Replace direct dma_async_tx_descriptor->tx_submit() calls with the
> > > proper dmaengine_submit() API wrapper.
> > >
> > > Assisted-by: LLM
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> >
> > Hi Frank,
> >
> > Is there a back-story to this change?
> > Is it part of something larger?
>
> Yep, Frank has been fixing direct calls with wrappers with aim to
> eventually start moving dmaengine guts internal and have a good
> consumer/provider split of the engine and objects
Thanks,
In that case all looks good to me.
>
> > In face value it looks like a cleanup to an unmaintained driver.
> > And if so, I'm not sure it's worth the churn.
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-10-09 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 19:30 [PATCH 1/1] net: ethernet: micrel: ks8842: use dmaengine_submit() instead of ->tx_submit() Frank.Li
2026-10-07 14:43 ` Simon Horman
2026-10-07 15:11 ` Vinod Koul
2026-10-09 10:36 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261009103622.GY83879@horms.kernel.org \
--to=horms@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Frank.Li@oss.nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vkoul@kernel.org \
--cc=yiconghui@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox