Re: [PATCH 2/2] i3c: master: svc: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts <crofts@kernel.org>]

On Wed, 11 Nov 2026 14:43:33 -0500
Frank Li <Frank.li@oss.nxp.com> wrote:

> On Sat, Nov 07, 2026 at 01:30:08PM +0100, Joshua Crofts wrote:
> > On Sat, 07 Nov 2026 12:06:24 +0100
> > Joshua Crofts <crofts@kernel.org> wrote:
> >  
> > > Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> > > driver core is now responsible for undoing any
> > > pm_runtime_use_autosuspend() calls on driver exit.
> > >
> > > Remove the redundant function calls.
> > >
> > > Signed-off-by: Joshua Crofts <crofts@kernel.org>
> > > ---
> > >  drivers/i3c/master/svc-i3c-master.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> > > index e700392f0801..9b845b2955be 100644
> > > --- a/drivers/i3c/master/svc-i3c-master.c
> > > +++ b/drivers/i3c/master/svc-i3c-master.c
> > > @@ -2084,7 +2084,6 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
> > >  	return 0;
> > >
> > >  rpm_disable:
> > > -	pm_runtime_dont_use_autosuspend(&pdev->dev);
> > >  	pm_runtime_put_noidle(&pdev->dev);
> > >  	pm_runtime_disable(&pdev->dev);
> > >  	pm_runtime_set_suspended(&pdev->dev);
> > > @@ -2101,7 +2100,6 @@ static void svc_i3c_master_remove(struct platform_device *pdev)
> > >
> > >  	i3c_master_unregister(&master->base);
> > >
> > > -	pm_runtime_dont_use_autosuspend(&pdev->dev);
> > >  	pm_runtime_disable(&pdev->dev);
> > >  }
> > >
> > >  
> >
> > Okay, after reading Sashiko's review it seems that this patch won't
> > be as straight forward as I thought. I'm thinking of manually
> > suspending the device in the remove() function or just removing
> > dont_use_autosuspend() from the probe error path. Any thoughts?  
> 
> Just leave it as it now. I will fix it later.

Cool. Thanks Frank!

-- 
Kind regards,
Joshua Crofts