RE: [PATCH 06/14] arm64: dts: freescale: imx93-tqma9352-mba93xxla: improve pad configuration

Peng Fan
2024-08-01T03:04:52Z

> Subject: [PATCH 06/14] arm64: dts: freescale: imx93-tqma9352-
> mba93xxla: improve pad configuration
>
> From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
>
> - disable PU/PD if already done with external resistors
> - do not configure Schmitt Trigger for outputs
> - do not configure DSE / FSEL for inputs
> - add missing pad groups
> - assign muxed GPIO pads for X1 to gpio2 node
>
> Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> .../freescale/imx93-tqma9352-mba93xxla.dts | 237 ++++++++++++----
> --
> 1 file changed, 164 insertions(+), 73 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352-
> mba93xxla.dts b/arch/arm64/boot/dts/freescale/imx93-tqma9352-
> mba93xxla.dts
> index e2ee9f5a042c..c663b6585c3a 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts
> @@ -222,6 +222,11 @@ rtc-irq-hog {
> };
> };
>
> +&gpio2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpio2>;

I am not sure this is correct, what are this used for?

And this is new, not pad improvement.

I would prefer the other improvement part merged
with patch 2.

> +};
> +
> &gpio3 {
> ethphy-eqos-irq-hog {
> gpio-hog;
> @@ -509,25 +514,39 @@ &usdhc2 {
> };
>
> &iomuxc {
> + pinctrl_afe: afegrp {

no users?

Regards,
Peng.