From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F1BD31986F for ; Fri, 7 Nov 2025 10:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762512600; cv=none; b=DqtamqrzszIT4FIDsYAFlDdpg1t8dAQneIHsl/kuAJAaq+EkkQPgp6Gnr66jlUBNgAMXOmmA3OKsFGTRFrnNPN7vTT90jAOUtia4H/8DeZe3NTNyhp6c0GT3hsPqESCnxl9jvvWjE6pnfg0eYEzqphV2nQTjFL4IZwkmxDJDDAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762512600; c=relaxed/simple; bh=k6CWVoo79rJIhFxcP1Zi6lbWRJyVheMfi9XXd+LkGTU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZvnEGE2XnL9d/inR1bIq528MJSthDNSNWTgTSXlkfUPIt7MDGVR7PnjQCG+1yQW8v82YquIE/2GXqC5j6f6rthrhK3RqauN3R+6n2EXdKrLeAcxKTsmPVEeZZlTYbVpqOjAFE2Etp8Uk6WfuqOKH1AZhJ5BGOmpX5KiBiuWXxjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j19zi5vc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jpNWyLpt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j19zi5vc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jpNWyLpt" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A73MRNb1864565 for ; Fri, 7 Nov 2025 10:49:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=j19zi5vcZvZc+J3h eil5EXgb7o+MHafKBi9Slf1MAsHwht9ShJKuhVBN4IuNbfkFvOasu8HUs+laic1i ApQFCQDDkr0nR1Z4s/mFsEJRFNaTWW7B62zkTCNyqa8FVCGzmDgnRi4aJaWpx3yo 7YBrhqEKVuWBhNuAaoE60NFeKFuxZH+p+rn0tyDvgwMCTDDPUaOdyqcmIN20Yni7 e+FAQn327eA/EMJkdOZ1oKcI5NWQiBeaIRCP9KmnXRYAWj3UM/IlF2kolv1vNI8Y 9Rr7K9olNJaawFxFkksQTdDzKZOepplYR1QpfkBYS3jwKcxtOTKS7ODirqnsgtuo rorS0A== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a98ta17gq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Nov 2025 10:49:57 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4e8a35e1923so1888201cf.3 for ; Fri, 07 Nov 2025 02:49:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762512597; x=1763117397; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=jpNWyLptGFooiFNSHDLaXE5HjnuCuZ0g8SokYNKTO8+IVCdAwR43MCs8tn08eVT+RM R1BGP4gmpUrHhV5NnDk//drYG3iF4d52YNireJK3BuJHPBy1k2cGhi3RRN0nY5IziRDo sVExY7BG+RN5i6HvdfgfqEMO3YGxx5YoQ3Y8/IouHfzcBmbdpJjj4JgOMdD/tYoz8rsm +M0C86hTEeaCZSs15xKiQTFFD1fiIF233CFbk7kgiMZ590CPUvlszHJCeKWLZZk5zwtd oyackZhOAD8zEnBb2FyMOTBKyE2FDiwQK+XMzbTDG/GGwA4+wHn2sv3dQOdxcwDH/aOZ HUkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762512597; x=1763117397; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qy4xZjaDaueCuwPTRvX9IC7D9BFWUmRUOg/PJT9rm94=; b=LoMVLo3cZmuxMp/htxgHSoWem6fCVciZvZE/1dkxC4nDDHWv2TXncYoTmYcmZXt3DE utcdSfR9kNnbNHa6L4lOocwfplkV91jC+mJLsc3fpCSZuwascXx8asG1DfKQuC5vARXI rZvDLhwX5OfGMbiCLyXiKiLb0f6Coy7LfWZoGMh/MeVpAzbsbPA2pLjo4CwcnfPh+8vT 82ZKP99UPLBR53JBdj4hRkK8b4sHw6csE/q/xkbpE5xCambRmXKD8ShX6wNOciXI/SKH fQW6V2YrF1V6CjzIEN+5ZZz+WtYFnW+n693scMT4snYWCcWnOTVnorrRQ9RbIMIEnKgE WbTw== X-Forwarded-Encrypted: i=1; AJvYcCWwsHcuc9ki7EO+R7qwTBVNidBolyKKu2PlI4bdDCrP+ZOBJKfaGP6h6YaZdCNb4+RlsjQ=@lists.linux.dev X-Gm-Message-State: AOJu0YzlhghWD1U4wL0OylUvGmwVwEd9DQYhfW3h+GXVl/IRORUF1IvL nm1Nqeh5nwfzgsaMWxWsO9ojsYe8qNYGZjUj0ZD1tHpeZ4VgI9Z7cUAkobQk5y9MZRjxIsnNB4d pTTtqNTImUxupu92uiuiHaRf8Lw9HqLW7HhGz+TY74lprxWut9W//+bE= X-Gm-Gg: ASbGncusOAxsvtNf4EmOJZWzRpXjM2jXGOuUI9H43vDA+gkpeCUYCN8CFj2OuTVIf9B 37WrecCwsVmzM9tSVf+WORoF2Ro//6rGFEIpmGDFE50w7d/Fky/PrNC3OhB9JkVbSMaxMA8BzA7 hHmAqQNXhfkhNxeWfY6X5VvnQLP33K4lzqSG5kuBZsh1+L2qq696APLppfCD0Oab1fPA/PTyTgL szNiCv0EOcGsymfNcvKbYsKQFqFmrKIKXEQFuKqYn5f+r7h1h4o2IPZCVeufh7JHa6B53VBhqXA C/XY0ZtxRT/fidspnXLpGbAm5v+8Pt6YTAWXWfqeH8x/crrlc0Y0wPZQllFnojP8bettge38u+q 5Mn/6mefOlWfpR50ViY7d+RSaGH2HvTm6fVdC8M5wMt5FLsK9MDigAL0w X-Received: by 2002:ac8:5a51:0:b0:4e8:966b:459b with SMTP id d75a77b69052e-4ed949bb0f9mr18063051cf.5.1762512596799; Fri, 07 Nov 2025 02:49:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFb3Xbou/G0Zzd63eLA+eutWoqm0V75Q2RL/wdtW4sHDSzQGKhPaQSn2W6oLQojU83FQkCi9A== X-Received: by 2002:ac8:5a51:0:b0:4e8:966b:459b with SMTP id d75a77b69052e-4ed949bb0f9mr18062921cf.5.1762512596362; Fri, 07 Nov 2025 02:49:56 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bf9bc2fcsm204678566b.50.2025.11.07.02.49.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Nov 2025 02:49:55 -0800 (PST) Message-ID: <21a3d269-76e6-4da9-aa25-bfd1fb6dfb07@oss.qualcomm.com> Date: Fri, 7 Nov 2025 11:49:48 +0100 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/8] net: stmmac: qcom-ethqos: use generic device properties To: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Jose Abreu , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Matthew Gerlach , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Keguang Zhang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Lad Prabhakar , Heiko Stuebner , Chen Wang , Inochi Amaoto , Emil Renner Berthing , Minda Chen , Drew Fustini , Guo Ren , Fu Wei , Nobuhiro Iwamatsu , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Shuang Liang , Zhi Li , Shangjuan Wei , "G. Jaya Kumaran" , Clark Wang , Linux Team , Frank Li , David Wu , Samin Guo , Christophe Roullier , Swathi K S Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski References: <20251107-qcom-sa8255p-emac-v5-0-01d3e3aaf388@linaro.org> <20251107-qcom-sa8255p-emac-v5-2-01d3e3aaf388@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251107-qcom-sa8255p-emac-v5-2-01d3e3aaf388@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA3MDA4NyBTYWx0ZWRfXymesLsTxq7o5 C8Ud358c7lBwdiZezQ6GwyST+vvpRmiXGj8Af9lUqv8TxjzIlH6uO9UU8XShCgJvdreYreRbpM5 wGpo+lgFeiNwSHtpBGUbjFzsDCSmzzqrccDUkgJB6uP7gCqzowMJjdr6+ZdGF4iyaZV371IN7Xe K200lje+TXdsw1d4OA7V3ug3+iwym+sd61YOQcJyGbDpb1oqiig8eZi7uYgoIyqw4JY8Rk8xQbe fI716WMpu/AlKRtE7U8kyJvNUdQjmUTS0JCE4hSPpRT3OiAP1Yvv65X/zDW0O8Ah44pMEhKBaAb zg1RaAcrOECXber1KR6qGOy9iMYjTkkzs+PKXWO7PAJbKNw6FY+eDts+qxDcwWUywo8f/DCvSX1 qTMU7S/akMRzhhGmRHBPimJYFLRVmw== X-Proofpoint-ORIG-GUID: -GVGG1GL1oEIOc9EzJViJUm9ULhcQtkH X-Proofpoint-GUID: -GVGG1GL1oEIOc9EzJViJUm9ULhcQtkH X-Authority-Analysis: v=2.4 cv=G9IR0tk5 c=1 sm=1 tr=0 ts=690dced5 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=xTS94RJRWet4TjKJq7QA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-07_02,2025-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 malwarescore=0 clxscore=1011 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511070087 On 11/7/25 11:29 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > In order to drop the dependency on CONFIG_OF, convert all device property > getters from OF-specific to generic device properties and stop pulling > in any linux/of.h symbols. > > Signed-off-by: Bartosz Golaszewski > --- [...] > - if (of_property_read_bool(np, "snps,tso")) > + if (device_property_present(dev, "snps,tso")) This is a change in behavior - "snps,tso = <0>" would have previously returned false, it now returns true although it seems like it's the plat driver clunkily working around not including the common compatible and inlining parts of the common probe functions.. Konrad