From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ciprian Costea <ciprianmarian.costea@oss.nxp.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, NXP S32 Linux <s32@nxp.com>,
imx@lists.linux.dev, Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support
Date: Fri, 29 Nov 2024 17:05:06 +0100 [thread overview]
Message-ID: <251054e3-f80c-4feb-bb07-b581d7433933@kernel.org> (raw)
In-Reply-To: <20241129142535.1171249-2-ciprianmarian.costea@oss.nxp.com>
On 29/11/2024 15:25, Ciprian Costea wrote:
> + properties:
> + interrupts:
> + items:
> + - description: Message Buffer interrupt for mailboxes 0-7 and Enhanced RX FIFO
> + - description: Device state change
> + - description: Error detection
> + - description: Message Buffer interrupt for mailboxes 8-127
> + interrupt-names:
> + items:
> + - const: mb-0
> + - const: state
> + - const: berr
> + - const: mb-1
> + required:
> + - compatible
> + - reg
Drop, aren't they already required?
> + - interrupts
> + - interrupt-names
> + else:
> + properties:
> + interrupts:
> + maxItems: 1
Missing constraints for interrupt-names, e.g. :false.
> +
> additionalProperties: false
>
> examples:
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-29 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 14:25 [PATCH v3 0/3] add FlexCAN support for S32G2/S32G3 SoCs Ciprian Costea
2024-11-29 14:25 ` [PATCH v3 1/3] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support Ciprian Costea
2024-11-29 14:37 ` Marc Kleine-Budde
2024-11-29 15:20 ` Ciprian Marian Costea
2024-11-29 16:05 ` Krzysztof Kozlowski [this message]
2024-12-02 12:25 ` Ciprian Marian Costea
2024-11-29 14:25 ` [PATCH v3 2/3] can: flexcan: Add quirk to handle separate interrupt lines for mailboxes Ciprian Costea
2024-11-29 14:25 ` [PATCH v3 3/3] can: flexcan: add NXP S32G2/S32G3 SoC support Ciprian Costea
-- strict thread matches above, loose matches on Subject: below --
2024-11-19 8:01 [PATCH v3 0/3] add FlexCAN support for S32G2/S32G3 SoCs Ciprian Costea
2024-11-19 8:01 ` [PATCH v3 1/3] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support Ciprian Costea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=251054e3-f80c-4feb-bb07-b581d7433933@kernel.org \
--to=krzk@kernel.org \
--cc=aruizrui@redhat.com \
--cc=ciprianmarian.costea@oss.nxp.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox