Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run.com>
To: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	Mikhail Anikin <mikhail.anikin@solid-run.com>,
	Alexander Dahl <ada@thorsis.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] arm64: dts: imx8dxl: Add SolidRun SoM and HummingBoard
Date: Tue, 12 May 2026 10:27:02 +0000	[thread overview]
Message-ID: <25e8c090-aaea-4898-b3bb-14c71bcab41e@solid-run.com> (raw)
In-Reply-To: <557f7332-42b4-49eb-85ea-76d141a2150f@lunn.ch>

Hi Andrew,

Am 11.05.26 um 15:29 schrieb Andrew Lunn:
> On Mon, May 11, 2026 at 02:24:38PM +0300, Vladimir Oltean wrote:
>> On Mon, May 11, 2026 at 12:11:31PM +0200, Josua Mayer wrote:
>>> +&eqos {
>>> +	/* delays are added by connected ethernet-switch cpu port */
>>> +	phy-mode = "rgmii";
> For ethernet-phy combinations i'm pretty strict, but i'm more
> forgiving when switches are involved.
>
> If rx/tx-internal-delays-ps work, that would be better, but i'm
> willing to accept this, with the comment in place.
Only some stmmac driver variants handle delays, dwmac-imx is not one
of them. it cares neither for phy-mode nor rx/tx-internal-delay-ps.

So I wouldn't mind putting instead

phy-mode = "rgmii-id";
rx-internal-delay-ps = <0>;
tx-internal-delay-ps = <0>;

with the same comment, as long as it is more correct.

      reply	other threads:[~2026-05-12 10:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 10:11 [PATCH v4 0/2] arm64: dts: imx8dxl: Add SolidRun SoM and HummingBoard Josua Mayer
2026-05-11 10:11 ` [PATCH v4 1/2] dt-bindings: arm: fsl: Add SolidRun i.MX8DXL " Josua Mayer
2026-05-11 10:11 ` [PATCH v4 2/2] arm64: dts: imx8dxl: Add SolidRun " Josua Mayer
2026-05-11 11:24   ` Vladimir Oltean
2026-05-11 12:30     ` Josua Mayer
2026-05-11 12:50       ` Vladimir Oltean
2026-05-11 13:29     ` Andrew Lunn
2026-05-12 10:27       ` Josua Mayer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25e8c090-aaea-4898-b3bb-14c71bcab41e@solid-run.com \
    --to=josua@solid-run.com \
    --cc=Frank.Li@nxp.com \
    --cc=ada@thorsis.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikhail.anikin@solid-run.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=yazan.shhady@solid-run.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox