From: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chester Lin <chester62515@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Ghennadi Procopciuc <Ghennadi.Procopciuc@nxp.com>,
Larisa Grigore <larisa.grigore@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Lee Jones <lee@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Dong Aisheng <aisheng.dong@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
NXP S32 Linux Team <s32@nxp.com>,
Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
imx@lists.linux.dev
Subject: Re: [PATCH v5 1/7] dt-bindings: mfd: add support for the NXP SIUL2 module
Date: Mon, 4 Nov 2024 13:21:25 +0200 [thread overview]
Message-ID: <32c1a67d-57c8-4357-a7f0-3537b5d616a2@oss.nxp.com> (raw)
In-Reply-To: <vlkhmja7xjfjin5yffnet5ava62shsoflmkzfav6c2ylh3o6kk@hvpnmd4uyjca>
Hi Krzysztof,
Thank you for your review!
>> +
>> + siul2: siul2@4009c000 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> e.g. pinctrl
I wasn't sure which name to pick since it's responsible for pinctrl, GPIO and, in the future,
nvmem cells. I guess I can choose pinctrl if you think it's ok.
I will address all of the other comments in v6.
Best regards,
Andrei
>
>> + compatible = "nxp,s32g2-siul2";
>> + reg = <0x4009c000 0x179c>,
>> + <0x44010000 0x17b0>;
>> + reg-names = "siul20", "siul21";
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-11-04 11:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 8:06 [PATCH v5 0/7] gpio: siul2-s32g2: add initial GPIO driver Andrei Stefanescu
2024-11-01 8:06 ` [PATCH v5 1/7] dt-bindings: mfd: add support for the NXP SIUL2 module Andrei Stefanescu
2024-11-01 18:11 ` Frank Li
2024-11-04 11:11 ` Andrei Stefanescu
2024-11-02 8:42 ` Krzysztof Kozlowski
2024-11-04 11:21 ` Andrei Stefanescu [this message]
2024-11-01 8:06 ` [PATCH v5 2/7] mfd: nxp-siul2: add support for NXP SIUL2 Andrei Stefanescu
2024-11-01 17:18 ` kernel test robot
2024-11-01 18:20 ` Frank Li
2024-11-02 5:13 ` kernel test robot
2024-11-02 8:37 ` Dan Carpenter
2024-11-04 11:25 ` Andrei Stefanescu
2024-11-02 8:52 ` Krzysztof Kozlowski
2024-11-04 11:29 ` Andrei Stefanescu
2024-11-19 9:19 ` Krzysztof Kozlowski
2024-11-01 8:06 ` [PATCH v5 3/7] arm64: dts: s32g: make pinctrl part of mfd node Andrei Stefanescu
2024-11-01 18:22 ` Frank Li
2024-11-04 11:33 ` Andrei Stefanescu
2024-11-02 8:49 ` Krzysztof Kozlowski
2024-11-01 8:06 ` [PATCH v5 4/7] pinctrl: s32: convert the driver into an mfd cell Andrei Stefanescu
2024-11-01 11:53 ` Linus Walleij
2024-11-01 21:47 ` kernel test robot
2024-11-02 8:51 ` Krzysztof Kozlowski
2024-11-04 11:44 ` Andrei Stefanescu
2024-11-01 8:06 ` [PATCH v5 5/7] pinctrl: s32cc: change to "devm_pinctrl_register_and_init" Andrei Stefanescu
2024-11-01 11:54 ` Linus Walleij
2024-11-01 8:06 ` [PATCH v5 6/7] pinctrl: s32cc: add driver for GPIO functionality Andrei Stefanescu
2024-11-01 15:45 ` Markus Elfring
2024-11-04 11:45 ` Andrei Stefanescu
2024-11-01 8:06 ` [PATCH v5 7/7] MAINTAINERS: add MAINTAINER for NXP SIUL2 MFD driver Andrei Stefanescu
2024-11-01 11:56 ` [PATCH v5 0/7] gpio: siul2-s32g2: add initial GPIO driver Linus Walleij
2024-11-01 12:10 ` Andrei Stefanescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32c1a67d-57c8-4357-a7f0-3537b5d616a2@oss.nxp.com \
--to=andrei.stefanescu@oss.nxp.com \
--cc=Ghennadi.Procopciuc@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=aruizrui@redhat.com \
--cc=brgl@bgdev.pl \
--cc=chester62515@gmail.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=larisa.grigore@nxp.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=ping.bai@nxp.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox