From: Vladimir Zapolskiy <vz@mleia.com>
To: Frank Li <Frank.Li@nxp.com>,
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"moderated list:ARM/LPC32XX SOC SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: imx@lists.linux.dev
Subject: Re: [PATCH v2 3/5] ARM: dts: lpc3250-phy3250: add at25 required properties
Date: Sat, 15 Nov 2025 02:16:04 +0200 [thread overview]
Message-ID: <37edb265-90ff-43cf-bfeb-3371f12c78a8@mleia.com> (raw)
In-Reply-To: <20251114174712.1206027-3-Frank.Li@nxp.com>
Hi Frank.
On 11/14/25 19:47, Frank Li wrote:
> Add at25 required properties (size, address-width and pagesize), which
> duplicate deprecated properties.
>
> Fix below CHECK_DTB warning:
> arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dtb: at25@0 (atmel,at25): 'pagesize' is a required property
> arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dtb: at25@0 (atmel,at25): $nodename: 'anyOf' conditional failed, one must be fixed:
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> change in v2
> - move node name change to new patch
> ---
> arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> index 21a6d0bca1e8a..732d590f6cfdf 100644
> --- a/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> +++ b/arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts
> @@ -216,6 +216,10 @@ eeprom: at25@0 {
> at25,byte-len = <0x8000>;
> at25,addr-mode = <2>;
> at25,page-size = <64>;
> +
> + size = <0x8000>;
> + address-width = <16>;
> + pagesize = <64>;
> };
> };
>
I see that I was imprecise in my ask, please replace (remove) the deprecated
properties with the new ones added. There is no reason to keep both, forward
compatibility should not be supported.
Sorry for any caused confusion.
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2025-11-15 0:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 17:47 [PATCH v2 1/5] ARM: dts: lpc32xx: remove usb bus and elevate all children nodes Frank Li
2025-11-14 17:47 ` [PATCH v2 2/5] ARM: dts: lpc3250-ea3250: add key- prefix for gpio-keys Frank Li
2025-11-14 17:47 ` [PATCH v2 3/5] ARM: dts: lpc3250-phy3250: add at25 required properties Frank Li
2025-11-15 0:16 ` Vladimir Zapolskiy [this message]
2025-11-14 17:47 ` [PATCH v2 4/5] ARM: dts: lpc3250-phy3250: rename nodename at@0 to eeprom@0 Frank Li
2025-11-15 0:16 ` Vladimir Zapolskiy
2025-11-14 17:47 ` [PATCH v2 5/5] ARM: dts: lpc3250-phy3250: remove deprecated at25* property Frank Li
2025-11-15 0:23 ` Vladimir Zapolskiy
2025-11-17 16:12 ` Frank Li
2025-11-17 19:05 ` Vladimir Zapolskiy
2025-11-15 0:20 ` [PATCH v2 1/5] ARM: dts: lpc32xx: remove usb bus and elevate all children nodes Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37edb265-90ff-43cf-bfeb-3371f12c78a8@mleia.com \
--to=vz@mleia.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox