From: Vladimir Zapolskiy <vz@mleia.com>
To: "Uwe Kleine-König" <ukleinek@kernel.org>, "Frank Li" <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"open list:PWM SUBSYSTEM" <linux-pwm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: pwm: convert lpc1850-sct-pwm.txt to yaml format
Date: Mon, 16 Jun 2025 18:06:17 +0300 [thread overview]
Message-ID: <3dbd05d1-81be-4f08-8be8-6183bc58a1ee@mleia.com> (raw)
In-Reply-To: <hzcpjqvc7jygzt2xj25y7467b55gjv5w6bhgqq7plvzsom44wr@hzfzf6gth2we>
On 6/16/25 16:40, Uwe Kleine-König wrote:
> Hello Frank,
>
> On Mon, Jun 02, 2025 at 10:07:21AM -0400, Frank Li wrote:
>> +properties:
>> + compatible:
>> + const: nxp,lpc1850-sct-pwm
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + clock-names:
>> + items:
>> + - const: pwm
>> +
>> + resets:
>> + maxItems: 1
>
> Please add:
>
> '#pwm-cells':
> const: 3
>
> Otherwise looks fine.
>
With the requested change applied, please add
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
--
Best wishes,
Vladimir
prev parent reply other threads:[~2025-06-16 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 14:07 [PATCH 1/1] dt-bindings: pwm: convert lpc1850-sct-pwm.txt to yaml format Frank Li
2025-06-06 0:01 ` Rob Herring (Arm)
2025-06-16 13:40 ` Uwe Kleine-König
2025-06-16 15:06 ` Vladimir Zapolskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dbd05d1-81be-4f08-8be8-6183bc58a1ee@mleia.com \
--to=vz@mleia.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox