From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D96EF33A6FB; Wed, 3 Dec 2025 17:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764783737; cv=none; b=QCAab0w72gd6svAYL6nBwXjyb2gAdp1COkt+HLnVmd7aWm2aBO8No/M2qT6qWNcj84znrJo5JrEpe8paeFVVH3+YbvIWZuPsPg4qpYjAfsSCJyakBwEfShy5mHYlbo+YiNgyvPuZk5V1unnT4sCZLO5Kf6zq+GEe7uYqURODgpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764783737; c=relaxed/simple; bh=0PFD8diImxz9iIbuzHPx6vv4/igLNrwgU6UG5S0Ue64=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f0bLBKYTwIkGJhCtE3MXCwQqbIP/mX1t15rCzv7JsUwC+7Lm7etHGjHw6XFz9mXxInHShr2uBBWwBgJCCwNQiWDdDtilwr8VLRBPi86YTW6/UZGxNNvQwidsClFf9fAa5KqlDHPx3XFdkfrxHH8/OaHJqhHde1tuDgZMGjP8TrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=miD/O73f; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="miD/O73f" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83A14C4CEF5; Wed, 3 Dec 2025 17:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764783736; bh=0PFD8diImxz9iIbuzHPx6vv4/igLNrwgU6UG5S0Ue64=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=miD/O73fflM78imiiO7BcAz2xqJOUDcwGHSbdkxoM0weNUQAXdN9kDoG3FWGarMJr oMoarFhsAsrDZGZVZBofKu/vz4iMH+Pa6QJLFU9WzO0js6PzzErSnaYgGFxTGhDLD/ HlZ+VER72MkNKb9bm+YhBSL7S3oH5vUKrDCPaCvvxfbjjNABRSb59iS7czt4I2OCWC lJdX69w7JWqtLJzCzfdpAhXAWj5XvH3jlRU3QAQeuLpXqaDPln8WcHn+l89bV2MvvT ytHFu7Axt6YIfW+9e3wWcY2kAVayX1GS8doiyTBKmu95QabXoCT9UC8ZYwmFilr2Ed UeBILDnFqvCog== Message-ID: <48d5895d-fde0-4795-8049-788fa3171fde@kernel.org> Date: Wed, 3 Dec 2025 18:42:11 +0100 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v20 3/7] firmware: imx: add driver for NXP EdgeLock Enclave To: Frank Li Cc: Pankaj Gupta , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20251203-imx-se-if-v20-0-a04a25c4255f@nxp.com> <20251203-imx-se-if-v20-3-a04a25c4255f@nxp.com> <1ee383c7-ccbc-4c90-adf3-bfbe87fb6765@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/12/2025 17:59, Frank Li wrote: > On Wed, Dec 03, 2025 at 08:20:50AM +0100, Krzysztof Kozlowski wrote: >> On 03/12/2025 07:48, Pankaj Gupta wrote: >>> Add driver for enabling MU based communication interface to secure-enclave. >>> >>> NXP hardware IP(s) for secure-enclaves like Edgelock Enclave(ELE), are >>> embedded in the SoC to support the features like HSM, SHE & V2X, using >>> message based communication interface. >>> >>> The secure enclave FW communicates with Linux over single or multiple >>> dedicated messaging unit(MU) based interface(s). >>> Exists on i.MX SoC(s) like i.MX8ULP, i.MX93, i.MX95 etc. >>> >>> For i.MX9x SoC(s) there is at least one dedicated ELE MU(s) for each >>> world - Linux(one or more) and OPTEE-OS (one or more). >>> >>> Other dependent kernel drivers will be: >>> - NVMEM: that supports non-volatile devices like EFUSES, >>> managed by NXP's secure-enclave. >>> >>> Signed-off-by: Pankaj Gupta >>> Reviewed-by: Frank Li >>> --- >>> drivers/firmware/imx/Kconfig | 13 ++ >>> drivers/firmware/imx/Makefile | 2 + >>> drivers/firmware/imx/ele_base_msg.c | 269 ++++++++++++++++++++++++ >>> drivers/firmware/imx/ele_base_msg.h | 95 +++++++++ >>> drivers/firmware/imx/ele_common.c | 333 ++++++++++++++++++++++++++++++ >>> drivers/firmware/imx/ele_common.h | 45 ++++ >>> drivers/firmware/imx/se_ctrl.c | 401 ++++++++++++++++++++++++++++++++++++ >>> drivers/firmware/imx/se_ctrl.h | 86 ++++++++ >>> include/linux/firmware/imx/se_api.h | 14 ++ >>> 9 files changed, 1258 insertions(+) >>> >>> diff --git a/drivers/firmware/imx/Kconfig b/drivers/firmware/imx/Kconfig >>> index 127ad752acf8..5fe96299b704 100644 >>> --- a/drivers/firmware/imx/Kconfig >>> +++ b/drivers/firmware/imx/Kconfig >>> @@ -55,3 +55,16 @@ config IMX_SCMI_MISC_DRV >>> core that could provide misc functions such as board control. >>> >>> This driver can also be built as a module. >>> + >>> +config IMX_SEC_ENCLAVE >>> + tristate "i.MX Embedded Secure Enclave - EdgeLock Enclave Firmware driver." >>> + depends on IMX_MBOX && ARCH_MXC && ARM64 >>> + select FW_LOADER >>> + default m if ARCH_MXC >>> + >>> + help >>> + Exposes APIs supported by the iMX Secure Enclave HW IP called: >>> + - EdgeLock Enclave Firmware (for i.MX8ULP, i.MX93), >>> + like base, HSM, V2X & SHE using the SAB protocol via the shared Messaging >>> + Unit. This driver exposes these interfaces via a set of file descriptors >>> + allowing to configure shared memory, send and receive messages. >>> diff --git a/drivers/firmware/imx/Makefile b/drivers/firmware/imx/Makefile >>> index 3bbaffa6e347..4412b15846b1 100644 >>> --- a/drivers/firmware/imx/Makefile >>> +++ b/drivers/firmware/imx/Makefile >>> @@ -4,3 +4,5 @@ obj-$(CONFIG_IMX_SCU) += imx-scu.o misc.o imx-scu-irq.o rm.o imx-scu-soc.o >>> obj-${CONFIG_IMX_SCMI_CPU_DRV} += sm-cpu.o >>> obj-${CONFIG_IMX_SCMI_MISC_DRV} += sm-misc.o >>> obj-${CONFIG_IMX_SCMI_LMM_DRV} += sm-lmm.o >>> +sec_enclave-objs = se_ctrl.o ele_common.o ele_base_msg.o >>> +obj-${CONFIG_IMX_SEC_ENCLAVE} += sec_enclave.o >>> diff --git a/drivers/firmware/imx/ele_base_msg.c b/drivers/firmware/imx/ele_base_msg.c >>> new file mode 100644 >>> index 000000000000..a070acbd895c >>> --- /dev/null >>> +++ b/drivers/firmware/imx/ele_base_msg.c >>> @@ -0,0 +1,269 @@ >>> +// SPDX-License-Identifier: GPL-2.0+ >>> +/* >>> + * Copyright 2025 NXP >>> + */ >>> + >>> +#include >>> + >>> +#include >>> +#include >>> +#include >>> + >>> +#include "ele_base_msg.h" >>> +#include "ele_common.h" >>> + >>> +#define FW_DBG_DUMP_FIXED_STR "ELE" >>> + >>> +int ele_get_info(struct se_if_priv *priv, struct ele_dev_info *s_info) >>> +{ >>> + struct se_api_msg *tx_msg __free(kfree) = NULL; >>> + struct se_api_msg *rx_msg __free(kfree) = NULL; >> >> No, don't use this syntax. This is explicitly discouraged. >> >> NAK > > Add link for reference. > > https://lore.kernel.org/all/CAHk-=whPZoi03ZwphxiW6cuWPtC3nyKYS8_BThgztCdgPWP1WA@mail.gmail.com/ This is since beginning documented in kernel, so contributor could read cleanup docs before using them. Above Linus remark is nothing new, he already wrote it ~2 years ago. Best regards, Krzysztof