From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Marek Vasut <marex@denx.de>, Peng Fan <peng.fan@nxp.com>,
Michael Walle <mwalle@kernel.org>,
Fabio Estevam <festevam@denx.de>,
Markus Niebel <Markus.Niebel@tq-group.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Max Merchel <Max.Merchel@ew.tq-group.com>,
Tim Harvey <tharvey@gateworks.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board
Date: Mon, 2 Jun 2025 18:17:49 +0200 [thread overview]
Message-ID: <5014a8ff-aa91-4ea4-81c5-7aeafc13b330@kernel.org> (raw)
In-Reply-To: <20250602140613.940785-1-Frank.Li@nxp.com>
On 02/06/2025 16:06, Frank Li wrote:
> Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB
typo: legacy
> warnings:
> arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../devicetree/bindings/arm/fsl.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index d3b5e6923e416..75e46ffe9ba8c 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1711,6 +1711,29 @@ properties:
> - traverse,ten64 # Ten64 Networking Appliance / Board
> - const: fsl,ls1088a
>
> + - description: lpc based Boards
> + items:
> + - enum:
> + - ea,lpc4357-developers-kit
> + - ciaa,lpc4337
> + - enum:
> + - nxp,lpc4337
> + - nxp,lpc4357
This feels wrong. Why 4337-based board is compatible with 4357 SoC? If
this was intentional either DTS is wrong or commit msg needs explanation.
> + - const: nxp,lpc4350
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-02 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 14:06 [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board Frank Li
2025-06-02 15:34 ` Vladimir Zapolskiy
2025-06-02 16:04 ` Frank Li
2025-06-02 17:17 ` Vladimir Zapolskiy
2025-06-02 22:09 ` Frank Li
2025-06-06 0:00 ` Rob Herring
2025-06-02 16:17 ` Krzysztof Kozlowski [this message]
2025-06-02 22:19 ` Frank Li
2025-06-03 6:49 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5014a8ff-aa91-4ea4-81c5-7aeafc13b330@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Markus.Niebel@tq-group.com \
--cc=Max.Merchel@ew.tq-group.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=francesco.dolcini@toradex.com \
--cc=frieder.schrempf@kontron.de \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mwalle@kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox