From: Daniel Baluta <daniel.baluta@oss.nxp.com>
To: sashiko-reviews@lists.linux.dev,
Daniel Baluta <daniel.baluta@nxp.com>,
konradybcio@kernel.org
Cc: Frank.Li@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v4 1/3] soc: qcom: ubwc: Fix link error when QCOM_SMEM=n
Date: Thu, 13 Aug 2026 08:32:36 +0300 [thread overview]
Message-ID: <536631d2-b4fa-4f73-adcf-dd76744989be@oss.nxp.com> (raw)
In-Reply-To: <20260812155001.6A2D51F00A3A@smtp.kernel.org>
On 8/12/26 18:50, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [High] The patch adds `depends on QCOM_SMEM` to `QCOM_UBWC_CONFIG` but misses that `VIDEO_QCOM_IRIS` unconditionally selects it, causing an unmet dependency warning and leaving the original linker error unfixed.
> - [High] The conditional select in `DRM_MSM` creates a configuration where a built-in driver calls a function from a module, resulting in a linker error.
these two are addressed in patches 2/3 and 3/3.
next prev parent reply other threads:[~2026-08-13 5:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 15:19 [PATCH v4 0/3] soc: qcom: ubwc: Fix link error Daniel Baluta
2026-08-12 15:19 ` [PATCH v4 1/3] soc: qcom: ubwc: Fix link error when QCOM_SMEM=n Daniel Baluta
2026-08-12 15:50 ` sashiko-bot
2026-08-13 5:32 ` Daniel Baluta [this message]
2026-08-12 15:19 ` [PATCH v4 2/3] media: iris: Fix unmet dependency " Daniel Baluta
2026-08-12 15:19 ` [PATCH v4 3/3] soc: qcom: ubwc: Use IS_REACHABLE() instead of IS_ENABLED() Daniel Baluta
2026-08-12 15:32 ` sashiko-bot
2026-08-13 23:23 ` [PATCH v4 0/3] soc: qcom: ubwc: Fix link error Nathan Chancellor
2026-08-14 6:42 ` Daniel Baluta
2026-08-14 17:06 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536631d2-b4fa-4f73-adcf-dd76744989be@oss.nxp.com \
--to=daniel.baluta@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=imx@lists.linux.dev \
--cc=konradybcio@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox