From: Daniel Baluta <daniel.baluta@oss.nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Frieder Schrempf <frieder@fris.de>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, Frank Li <Frank.Li@nxp.com>,
imx@lists.linux.dev, Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v2 4/4] arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree
Date: Fri, 20 Feb 2026 14:27:30 +0200 [thread overview]
Message-ID: <53e69d31-c435-4fb8-8e4d-63a4e27887a1@oss.nxp.com> (raw)
In-Reply-To: <CAOMZO5B7kYtXzKtguYe=2YEnSm6rwa0vTHJwn1p6pUqjgZ-b4g@mail.gmail.com>
On 2/20/26 13:57, Fabio Estevam wrote:
> On Fri, Feb 20, 2026 at 8:20 AM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote:
>> On 2/20/26 12:36, Frieder Schrempf wrote:
>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>
>>> To make the code more readable, use the macros for the GPIO and IRQ
>>> settings.
>>>
>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>>
>> Typically your Signed-off-by tag should come last so you need to swap S-o-b with R-b tags
>>
>> in the commit message above.
> Is this suggestion valid?
>
> Shouldn't the tags appear in chronological order?
Tools like b4 indeed are taking the tags in chronological order.
But I always considered that when sending next version you pick all the tags
and then add your Signed-off-by last.
E.g https://www.spinics.net/lists/kernel/msg5995225.html
next prev parent reply other threads:[~2026-02-20 12:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 10:36 [PATCH v2 0/4] Kontron i.MX8MP OSM Devicetree Fixups Frieder Schrempf
2026-02-20 10:36 ` [PATCH v2 1/4] arm64: dts: imx8mp-kontron: Fix touch reset configuration on DL devices Frieder Schrempf
2026-02-20 10:36 ` [PATCH v2 2/4] arm64: dts: imx8mp-kontron: Drop vmmc-supply to fix SD card on SMARC eval carrier Frieder Schrempf
2026-02-20 10:36 ` [PATCH v2 3/4] arm64: dts: imx8mp-kontron: Fix boot order for PMIC and RTC Frieder Schrempf
2026-02-20 10:36 ` [PATCH v2 4/4] arm64: dts: imx8mp-kontron: Use GPIO/IRQ defines in DL devicetree Frieder Schrempf
2026-02-20 11:23 ` Daniel Baluta
2026-02-20 11:57 ` Fabio Estevam
2026-02-20 12:27 ` Daniel Baluta [this message]
2026-02-23 8:32 ` Frieder Schrempf
2026-03-06 16:02 ` [PATCH v2 0/4] Kontron i.MX8MP OSM Devicetree Fixups Frank Li
2026-03-06 17:42 ` Frank Li
2026-03-09 9:00 ` Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53e69d31-c435-4fb8-8e4d-63a4e27887a1@oss.nxp.com \
--to=daniel.baluta@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=frieder@fris.de \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox